From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-cmake: reduce output when being silent
Date: Wed, 11 Feb 2015 21:14:20 +0100 [thread overview]
Message-ID: <20150211211420.57208953@free-electrons.com> (raw)
In-Reply-To: <1423677141-10912-1-git-send-email-fabio.porcedda@gmail.com>
Dear Fabio Porcedda,
On Wed, 11 Feb 2015 18:52:21 +0100, Fabio Porcedda wrote:
> +ifdef QUIET
> +CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
> +else
> +CMAKE_QUIET =
> +endif
Use:
ifneq ($(QUIET),)
CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
endif
We generally don't use ifdef to test the value of a variable in
Buildroot.
The else part is unnecessary.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-11 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 17:52 [Buildroot] [PATCH] pkg-cmake: reduce output when being silent Fabio Porcedda
2015-02-11 20:14 ` Thomas Petazzoni [this message]
[not found] ` <CAHkwnC9TyTDnd0jfcVtoX0fO3N5xDD7eeWqbqATtF+-pMcatOA@mail.gmail.com>
2015-02-12 21:20 ` Fabio Porcedda
2015-02-14 8:01 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211211420.57208953@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox