Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/openmvtools: don't use host library path
Date: Sat, 14 Feb 2015 09:22:06 +0100	[thread overview]
Message-ID: <20150214092206.71b95d13@free-electrons.com> (raw)
In-Reply-To: <1423437730-22997-3-git-send-email-romain.naour@openwide.fr>

Dear Romain Naour,

On Mon,  9 Feb 2015 00:22:10 +0100, Romain Naour wrote:

>  ifeq ($(BR2_PACKAGE_OPENVMTOOLS_PROCPS),y)
> -OPENVMTOOLS_CONF_ENV += CUSTOM_PROCPS_NAME=procps
> +OPENVMTOOLS_CONF_ENV += CUSTOM_PROCPS_NAME=procps \
> +	CUSTOM_PROCPS_LIBS="-L$(STAGING_DIR)"

This is wrong, because $(STAGING_DIR) does not contain libraries. It
should either be -L$(STAGING_DIR)/usr/lib and/or
-L$(STAGING_DIR)/usr/lib. And also, please add a comment above this to
explain why we are passing this explicitly (it should normally not be
needed).

I've marked this patch as Changes Requested in patchwork.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-02-14  8:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 23:22 [Buildroot] [PATCH 1/3] package/openvmtools: configure fix USE_SLASH_PROC Romain Naour
2015-02-08 23:22 ` [Buildroot] [PATCH 2/3] package/openvmtools: fix syncDriverPosix Romain Naour
2015-02-14  8:20   ` Thomas Petazzoni
2015-02-14 11:38     ` Romain Naour
2015-02-15 20:55       ` Károly Kasza
2015-02-15 21:19         ` Thomas Petazzoni
2015-02-19  0:41         ` Romain Naour
2015-02-08 23:22 ` [Buildroot] [PATCH 3/3] package/openmvtools: don't use host library path Romain Naour
2015-02-14  8:22   ` Thomas Petazzoni [this message]
2015-02-14  8:23   ` Thomas Petazzoni
2015-02-14 11:38     ` Romain Naour
2015-02-14  8:18 ` [Buildroot] [PATCH 1/3] package/openvmtools: configure fix USE_SLASH_PROC Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150214092206.71b95d13@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox