From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] br-reproduce-build: quote all variables
Date: Sat, 14 Feb 2015 23:00:03 +0100 [thread overview]
Message-ID: <20150214220003.GG3886@free.fr> (raw)
In-Reply-To: <20150214221046.69bc7075@free-electrons.com>
Thomas, All,
On 2015-02-14 22:10 +0100, Thomas Petazzoni spake thusly:
> On Sat, 14 Feb 2015 11:52:06 +0100, Yann E. MORIN wrote:
>
> > -wget -O ${BUILD_DIR}/config http://autobuild.buildroot.org/results/${BUILD_ID}/config
> > +wget -O "${BUILD_DIR}/config http://autobuild.buildroot.org/results/${BUILD_ID}/config"
>
> How can this work? You're putting both the -O argument and the URL
> within the same quotes.
Indeed, it can not work. And I noticed that when testing, and I fixed
it, but...
> > -wget -O ${BUILD_DIR}/gitid http://autobuild.buildroot.org/results/${BUILD_ID}/gitid
> > +wget -O "${BUILD_DIR}/gitid http://autobuild.buildroot.org/results/${BUILD_ID}/gitid"
>
> Ditto.
... obviously, I forgot to commit --amend... :-(
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2015-02-14 22:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 10:52 [Buildroot] [pull request] buildroot-test: misc enhancenments for br-reproduce-build Yann E. MORIN
2015-02-14 10:52 ` [Buildroot] [PATCH 1/4] br-reproduce-build: accept BASE_GIT and OUTPUT_DIR from the env Yann E. MORIN
2015-02-14 21:08 ` Thomas Petazzoni
2015-02-15 0:30 ` Yann E. MORIN
2015-02-14 10:52 ` [Buildroot] [PATCH 2/4] br-reproduce-build: use current directory as the default for outputs Yann E. MORIN
2015-02-14 21:08 ` Thomas Petazzoni
2015-02-14 10:52 ` [Buildroot] [PATCH 3/4] br-reproduce-build: fix URL of gitid Yann E. MORIN
2015-02-14 21:10 ` Thomas Petazzoni
2015-02-14 21:58 ` Yann E. MORIN
2015-02-18 20:12 ` Fabio Porcedda
2015-02-18 20:26 ` Yann E. MORIN
2015-02-18 20:37 ` Fabio Porcedda
2015-02-14 10:52 ` [Buildroot] [PATCH 4/4] br-reproduce-build: quote all variables Yann E. MORIN
2015-02-14 21:10 ` Thomas Petazzoni
2015-02-14 22:00 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214220003.GG3886@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox