From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/1] package/x11r7/xserver_xorg-server: Relax dependency on libdrm
Date: Thu, 19 Feb 2015 22:40:31 +0100 [thread overview]
Message-ID: <20150219224031.45cb0bb0@free-electrons.com> (raw)
In-Reply-To: <1424006372-4230-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sun, 15 Feb 2015 14:19:32 +0100, Bernd Kuhls wrote:
> xserver_xorg-server needs libdrm only when DRI is enabled, see configure.ac,
> line 1280. But since version 1.16.99.901 configure searches for optional libdrm
> support in configure.ac, line 2041,
>
> http://cgit.freedesktop.org/xorg/xserver/commit/configure.ac?id=2feda3b6b58f46cef91ea41312aac9021a703777
>
> as well due to libdrm support being enabled by default, but the macro
> PKG_CHECK_EXISTS used in line 2041 does not add libdrm-specific CFLAGS to
> Makefile causing the build to fail:
>
> In file included from dumb_bo.c:36:0:
> /home/br/br7/output/host/usr/i586-buildroot-linux-uclibc/sysroot/usr/include/xf86drm.h:40:17: fatal error: drm.h: No such file or directory
> #include <drm.h>
>
> This patch enables libdrm support only when dri support is enabled, which in
> turn depends on mesa3d. Since mesa3d selects libdrm already remove that line
> from Config.in as well.
>
> Tested using this defconfig
>
> BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> BR2_TOOLCHAIN_BUILDROOT_CXX=y
> BR2_PACKAGE_XORG7=y
> BR2_PACKAGE_XSERVER_XORG_SERVER=y
> BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR=y
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-02-19 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 13:19 [Buildroot] [PATCH next 1/1] package/x11r7/xserver_xorg-server: Relax dependency on libdrm Bernd Kuhls
2015-02-19 21:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219224031.45cb0bb0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox