Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8] wine: New package
Date: Tue, 24 Feb 2015 00:00:23 +0100	[thread overview]
Message-ID: <20150223230023.GB3950@free.fr> (raw)
In-Reply-To: <54EB7E36.6060303@dawncrow.de>

Andre, All,

On 2015-02-23 20:23 +0100, Andr? Hentschel spake thusly:
> Adds new package: wine

I have a very minor comment that can be fixed when the patch is applied,
no need to resend it...

[--SNIP--]
> diff --git a/package/wine/Config.in b/package/wine/Config.in
> new file mode 100644
> index 0000000..9a3b87f
> --- /dev/null
> +++ b/package/wine/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_WINE
> +	bool "wine"
> +	depends on BR2_TOOLCHAIN_USES_GLIBC
> +	# Wine only builds on certain architectures
> +	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
> +	# Wine has much CPU specific code and mostly makes sense on x86
> +	depends on BR2_i386
> +	help
> +	  Wine is a compatibility layer capable of running Windows
> +	  applications on Linux. Instead of simulating internal
> +	  Windows logic like a virtual machine or emulator, Wine
> +	  translates Windows API calls into POSIX calls on-the-fly,
> +	  eliminating the performance and memory penalties of other
> +	  methods.
> +
> +	  http://www.winehq.org
> +
> +comment "wine needs a (e)glibc toolchain w/ IPv6, threads"

You indeed removed the dependency on threads and IPv6, but forgot to
update the comment; stating "wine needs an (e)glibc toolchain" is
enough.

That's about all I have to say about this version. With the above fixed
before commiting:

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[Only build-tested, not run-time tested y lack of Windows apps]
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thank you for your persistence in this adventure! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-02-23 23:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 19:23 [Buildroot] [PATCH v8] wine: New package André Hentschel
2015-02-23 23:00 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150223230023.GB3950@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox