From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel
Date: Tue, 3 Mar 2015 14:31:25 +0100 [thread overview]
Message-ID: <20150303143125.75a1a4d3@free-electrons.com> (raw)
In-Reply-To: <1425385673-2462-1-git-send-email-fabienlahoudere.pro@gmail.com>
Dear Lahoudere Fabien,
On Tue, 3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro@gmail.com>
This should normally be:
Signed-off-by: <first name> <last name> <email>
> ---
> boot/barebox/barebox.mk | 2 ++
> 1 file changed, 2 insertions(+)
This looks good but the commit log could be improved:
barebox: fix compilation on x86-64 architecture
Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
currently handle the case of the x86-64 architecture. In this
case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
nonetheless.
The commit title should almost always look like:
<pkg>: <description>
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-03 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:27 [Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel Lahoudere Fabien
2015-03-03 13:31 ` Thomas Petazzoni [this message]
2015-03-03 14:25 ` Fabien Lahoudere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303143125.75a1a4d3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox