Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/4] python-cheetah: add host-package support
Date: Wed, 4 Mar 2015 22:49:40 +0100	[thread overview]
Message-ID: <20150304224940.69efc51c@free-electrons.com> (raw)
In-Reply-To: <1425484811-26238-3-git-send-email-gwenj@trabucayre.com>

Dear Gwenhael Goavec-Merou,

On Wed,  4 Mar 2015 17:00:10 +0100, Gwenhael Goavec-Merou wrote:

> diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk
> index 08076b5..faf2436 100644
> --- a/package/python-cheetah/python-cheetah.mk
> +++ b/package/python-cheetah/python-cheetah.mk
> @@ -9,5 +9,7 @@ PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz
>  PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah
>  PYTHON_CHEETAH_LICENSE = MIT
>  PYTHON_CHEETAH_SETUP_TYPE = setuptools
> +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown

Are you sure you need to add host-python-markdown as a dependency to
the target python-cheetah package ? I.e, I'd like to understand if what
you need is:

PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown

 (i.e adds host-python-markdown to the dependencies of both
 python-cheetah and host-python-cheetah)

*OR*

PYTHON_CHEETAH_DEPENDENCIES = python-markdown

 (i.e adds python-markdown to the dependencies of python-cheetah, and
 host-python-markdown to the dependencies of host-python-cheetah)

*OR*

HOST_PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown

 (i.e adds host-python-markdown to the dependencies of
 host-python-cheetah)

Also, use '=' and not '+=' in such situations.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-04 21:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 16:00 [Buildroot] [PATCH v3 1/4] pkg-cmake: allow to build package in a subdirectory Gwenhael Goavec-Merou
2015-03-04 16:00 ` [Buildroot] [PATCH v3 2/4] python-markdown: add host-package support Gwenhael Goavec-Merou
2015-03-04 21:47   ` Thomas Petazzoni
2015-03-04 16:00 ` [Buildroot] [PATCH v3 3/4] python-cheetah: " Gwenhael Goavec-Merou
2015-03-04 21:49   ` Thomas Petazzoni [this message]
2015-03-05  8:40     ` gwenhael.goavec
2015-03-05  8:54       ` Thomas Petazzoni
2015-03-04 16:00 ` [Buildroot] [PATCH v3 4/4] GNURadio: new package Gwenhael Goavec-Merou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304224940.69efc51c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox