From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 4 Mar 2015 23:29:09 +0100 Subject: [Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library In-Reply-To: <1425244013-2509-3-git-send-email-fabio.porcedda@gmail.com> References: <1425244013-2509-1-git-send-email-fabio.porcedda@gmail.com> <1425244013-2509-3-git-send-email-fabio.porcedda@gmail.com> Message-ID: <20150304232909.625985fa@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Fabio Porcedda, In the title: s/opt/popt/ On Sun, 1 Mar 2015 22:06:53 +0100, Fabio Porcedda wrote: > Without using the pkg-config the dependencies are not included for a > static linking so it fails to build. > These failures are fixed by linking the libintl library that is a > dependency of the opt library. s/opt/popt/ I've fixed and committed. Though I have one concern below. > + $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" \ > + LOADLIBES="$(shell $(PKG_CONFIG_HOST_BINARY) --libs popt)" \ It's not currently supported in Buildroot, but LOADLIBES is extended by the logrotate Makefile with -lacl or -lselinux when WITH_ACL or WITH_SELINUX are used. I'm not sure this will play well with your proposed solution. But ok, this can be handled when/if someone adds ACL and/or SELinux support to logrotate. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com