From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/efl/libevas: Switch to giflib
Date: Sat, 7 Mar 2015 17:32:34 +0100 [thread overview]
Message-ID: <20150307173234.57c8bf4f@free-electrons.com> (raw)
In-Reply-To: <CAHkwnC-cVh1fKVKyR=RhWv+tQgRVeQomt0dL1Z0TW_cbnyQ_+w@mail.gmail.com>
Dear Fabio Porcedda,
On Sat, 7 Mar 2015 17:29:56 +0100, Fabio Porcedda wrote:
> IMHO it's cleaner if instead of adding this patch you can add a
> post_patch hook that using sed change all "DGifCloseFile(gif)" to
> "DGifCloseFile(gif, NULL)".
I don't agree. Such sed expressions can very easily be overlooked when
bumping the package, and they don't solve a problem that should be
solved by submitting a patch to the upstream project.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-07 16:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 19:24 [Buildroot] [PATCH 1/5] package/giflib: New package Bernd Kuhls
2015-01-26 19:24 ` [Buildroot] [PATCH 2/5] package/fbv: Switch to giflib Bernd Kuhls
2015-01-27 15:17 ` Peter Korsgaard
2015-01-29 18:56 ` Bernd Kuhls
2015-01-26 19:24 ` [Buildroot] [PATCH 3/5] package/imlib2: " Bernd Kuhls
2015-01-27 15:25 ` Peter Korsgaard
2015-01-29 19:13 ` Bernd Kuhls
2015-03-07 18:09 ` Fabio Porcedda
2015-01-26 19:24 ` [Buildroot] [PATCH 4/5] package/efl/libevas: " Bernd Kuhls
2015-03-07 16:29 ` Fabio Porcedda
2015-03-07 16:32 ` Thomas Petazzoni [this message]
2015-03-07 17:01 ` Fabio Porcedda
2015-03-08 7:15 ` Thomas Petazzoni
2015-03-08 7:28 ` Fabio Porcedda
2015-03-08 7:46 ` Thomas Petazzoni
2015-03-08 7:54 ` Fabio Porcedda
2015-03-08 8:03 ` Thomas Petazzoni
2015-04-04 16:45 ` Thomas Petazzoni
2015-01-26 19:24 ` [Buildroot] [PATCH 5/5] package/libungif: deprecate package Bernd Kuhls
2015-03-07 17:19 ` Fabio Porcedda
2015-04-04 16:46 ` Thomas Petazzoni
2015-04-08 20:33 ` Bernd Kuhls
2015-01-27 15:12 ` [Buildroot] [PATCH 1/5] package/giflib: New package Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307173234.57c8bf4f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox