From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 8 Mar 2015 18:30:23 +0100 Subject: [Buildroot] [PATCH] openpgm: Blacklist Blackfin ADI 2014R1 toolchain In-Reply-To: <54FC7C44.1040707@openwide.fr> References: <1425754315-524-1-git-send-email-romain.naour@openwide.fr> <20150308085356.11aae236@free-electrons.com> <54FC7C44.1040707@openwide.fr> Message-ID: <20150308183023.06960971@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Romain Naour, On Sun, 08 Mar 2015 17:43:48 +0100, Romain Naour wrote: > > Also, at some point, we will need to really on the ARCH_HAS_ATOMICS > > stuff for this. > really -> rely Right. But it's not a commit log, so do we care about typos ? :-) > You mean BR2_ARCH_HAS_ATOMICS ? > But it's set by default for bfin configs. Yes. Back when we introduced BR2_ARCH_HAS_ATOMICS, but wondered whether it should be BR2_ARCH_HAS_ATOMICS or BR2_TOOLCHAIN_HAS_ATOMICS, i.e whether we would have the case of an architecture that does support atomic intrinsics, but has certain toolchain versions for this architecture that do not. I don't remember if we carefully check whether Blackfin has atomic intrinsics or not. > config BR2_ARCH_HAS_ATOMICS > # The following toolchains lack required compiler intrinsics > depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 > depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 > depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 > default y Nope. We first need to find out whether the Blackfin architecture has what's needed to provide atomic intrinsics. Depending on that, we'll now if it's a toolchain limitation or not. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com