From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] toolchain: fix installing gconv libs with multi-arch toolchain
Date: Sun, 8 Mar 2015 22:48:31 +0100 [thread overview]
Message-ID: <20150308224831.246ff970@free-electrons.com> (raw)
In-Reply-To: <1424643784-23210-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 22 Feb 2015 23:23:04 +0100, Yann E. MORIN wrote:
> diff --git a/toolchain/toolchain.mk b/toolchain/toolchain.mk
> index 3f9900b..51294c3 100644
> --- a/toolchain/toolchain.mk
> +++ b/toolchain/toolchain.mk
> @@ -17,28 +17,39 @@ endif
> ifeq ($(BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY),y)
> GCONV_LIBS = $(call qstrip,$(BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_LIST))
> define COPY_GCONV_LIBS
> - $(Q)if [ -z "$(GCONV_LIBS)" ]; then \
> - $(INSTALL) -m 0644 -D $(STAGING_DIR)/usr/lib/gconv/gconv-modules \
> - $(TARGET_DIR)/usr/lib/gconv/gconv-modules; \
> - $(INSTALL) -m 0644 $(STAGING_DIR)/usr/lib/gconv/*.so \
> + $(Q)machine=$$($(TOOLCHAIN_EXTERNAL_CC) $(TOOLCHAIN_EXTERNAL_CFLAGS) -dumpmachine); \
Unless I'm mistaken, this piece of code copying gconv libraries is used
for both the internal and external toolchain backends, no? If that's
the case, then using TOOLCHAIN_EXTERNAL_* here seems wrong, no?
And indeed, the resulting code is not really nice. For sure not worse
than the average toolchain-external.mk code :-/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-08 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 22:23 [Buildroot] [PATCHv2] toolchain: fix installing gconv libs with multi-arch toolchain Yann E. MORIN
2015-03-08 21:48 ` Thomas Petazzoni [this message]
2015-03-17 14:08 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150308224831.246ff970@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox