[Buildroot] [PATCH 1/3] Added new package 'mc' (Midnight Commander).

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Mauro Condarelli,

Thanks for this contribution!

On Sun,  8 Mar 2015 22:37:07 +0100, Mauro Condarelli wrote:

> diff --git a/package/mc/Config.in b/package/mc/Config.in
> new file mode 100644
> index 0000000..735523f
> --- /dev/null
> +++ b/package/mc/Config.in
> @@ -0,0 +1,10 @@
> +# mc prefers slang, but can use ncurses too

This comment should be right above the "select BR2_PACKAGE_SLANG" line.

> +config BR2_PACKAGE_MC
> +	bool "mc"
> +	select BR2_PACKAGE_LIBGLIB2

When you select a package, you need to replicate the dependencies of
this package. So here, you need to:

        depends on BR2_USE_WCHAR # libglib2
        depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
        depends on BR2_USE_MMU # libglib2, slang

> +	help
> +	  GNU Midnight Commander is a visual file manager, licensed under GNU General Public License.
> +	  It can use either SLang(preferred) or ncurses for screen handling; if neither is enabled SLang will be automatically chosen.

Please wrap text to 72 characters.

> +MC_VERSION_MAJOR = 4.8
> +MC_VERSION = $(MC_VERSION_MAJOR).13
> +MC_SOURCE = mc-$(MC_VERSION).tar.bz2
> +MC_SITE = http://ftp.midnight-commander.org
> +MC_INSTALL_STAGING = YES
> +MC_INSTALL_TARGET = YES
> +MC_CONF_OPTS = --disable-shared
> +MC_DEPENDENCIES = libglib2 host-pkgconf

You should add MC_LICENSE and MC_LICENSE_FILES variables.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com