Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/3] pkg-cmake: allow to build package in a subdirectory
Date: Mon, 9 Mar 2015 22:05:44 +0100	[thread overview]
Message-ID: <20150309220544.48fafdaa@free-electrons.com> (raw)
In-Reply-To: <1425553401-27461-1-git-send-email-gwenj@trabucayre.com>

Gwenhael, Samuel,

On Thu,  5 Mar 2015 12:03:19 +0100, Gwenhael Goavec-Merou wrote:

> +* +LIBFOO_BUILDDIR+ may overload the default build directory when a
> +  package prevents from in-source-tree build. For example,
> +  FOO_BUILDDIR = $(FOO_SRCDIR)/.build, will be used to compile foo
> +  package in .build subdirectory.

Is it really useful to be able to define the path to the build
directory? I believe we could do something simpler that consists in
just a boolean variable saying that the package does not accept
in-source build, like:

LIBFOO_SUPPORTS_IN_SOURCE_BUILD = NO

(which would default to YES)

and then the CMake package infra takes care of doing the build in some
$(@D)/buildroot-build/ directory, or something like that.

Thoughts?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-03-09 21:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 11:03 [Buildroot] [PATCH v4 1/3] pkg-cmake: allow to build package in a subdirectory Gwenhael Goavec-Merou
2015-03-05 11:03 ` [Buildroot] [PATCH v4 2/3] python-cheetah: add host-package support Gwenhael Goavec-Merou
2015-03-07 11:26   ` Samuel Martin
2015-03-05 11:03 ` [Buildroot] [PATCH v4 3/3] GNURadio: new package Gwenhael Goavec-Merou
2015-03-07 12:46   ` Samuel Martin
2015-03-09 10:22     ` gwenhael.goavec
2015-03-09 10:30       ` Thomas Petazzoni
2015-03-09 11:25         ` gwenhael.goavec
2015-03-09 21:03   ` Thomas Petazzoni
2015-03-07 11:25 ` [Buildroot] [PATCH v4 1/3] pkg-cmake: allow to build package in a subdirectory Samuel Martin
2015-03-09 21:05 ` Thomas Petazzoni [this message]
2015-03-09 21:25   ` Samuel Martin
2015-03-09 23:19   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309220544.48fafdaa@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox