Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 3/3] GNURadio: new package
Date: Fri, 13 Mar 2015 22:53:38 +0100	[thread overview]
Message-ID: <20150313225338.3f2c4796@free-electrons.com> (raw)
In-Reply-To: <1426235050-3482-3-git-send-email-gwenj@trabucayre.com>

Dear Gwenhael Goavec-Merou,

On Fri, 13 Mar 2015 09:24:10 +0100, Gwenhael Goavec-Merou wrote:

> +Index: gnuradio-3.7.5/volk/cmake/VolkBoost.cmake
> +===================================================================
> +--- gnuradio-3.7.5.orig/volk/cmake/VolkBoost.cmake
> ++++ gnuradio-3.7.5/volk/cmake/VolkBoost.cmake
> +@@ -29,7 +29,6 @@ set(__INCLUDED_VOLK_BOOST_CMAKE TRUE)
> + set(BOOST_REQUIRED_COMPONENTS
> +     filesystem
> +     system
> +-    unit_test_framework

It will probably be needed to re-add this unit_test_framework
dependency, but maybe only if BUILD_TEST is enabled, or something like
that.

> +     program_options
> + )
> + 
> +Index: gnuradio-3.7.5/volk/lib/CMakeLists.txt
> +===================================================================
> +--- gnuradio-3.7.5.orig/volk/lib/CMakeLists.txt
> ++++ gnuradio-3.7.5/volk/lib/CMakeLists.txt
> +@@ -540,8 +540,9 @@ endif(ENABLE_STATIC_LIBS)
> + # Build the QA test application
> + ########################################################################
> + 
> ++find_package(Boost "1.35" COMPONENTS "unit_test_framework")
> + 
> +-if(Boost_FOUND)
> ++if(Boost_FOUND AND BUILD_TEST)
> + 
> +     set_source_files_properties(
> +         ${CMAKE_CURRENT_SOURCE_DIR}/testqa.cc PROPERTIES
> +@@ -558,4 +559,4 @@ if(Boost_FOUND)
> +     target_link_libraries(test_all volk ${Boost_LIBRARIES})
> +     add_test(qa_volk_test_all test_all)
> + 
> +-endif(Boost_FOUND)
> ++endif(Boost_FOUND AND BUILD_TEST)

Can you please work with upstream to get this patch merged?


> +# host-python-cheetah is needed for volk to compile
> +GNURADIO_DEPENDENCIES = \
> +		host-python-cheetah \
> +		host-swig \
> +		boost

Indentation should be only one tab.

> +GNURADIO_CONF_OPTS = \
> +		-DENABLE_DEFAULT=OFF \
> +		-DENABLE_VOLK=ON \
> +		-DENABLE_GNURADIO_RUNTIME=ON

Ditto.

Committed with the indentation fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-13 21:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  8:24 [Buildroot] [PATCH v7 1/3] pkg-cmake: allow to build package in a subdirectory Gwenhael Goavec-Merou
2015-03-13  8:20 ` Angelo Compagnucci
2015-03-13  8:24 ` [Buildroot] [PATCH v7 2/3] python-cheetah: add host-package support Gwenhael Goavec-Merou
2015-03-13 21:51   ` Thomas Petazzoni
2015-03-15 21:15   ` Thomas Petazzoni
2015-03-13  8:24 ` [Buildroot] [PATCH v7 3/3] GNURadio: new package Gwenhael Goavec-Merou
2015-03-13 21:53   ` Thomas Petazzoni [this message]
2015-03-13  9:49 ` [Buildroot] [PATCH v7 1/3] pkg-cmake: allow to build package in a subdirectory Samuel Martin
2015-03-13 21:49 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313225338.3f2c4796@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox