From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 14 Mar 2015 22:45:37 +0100
Subject: [Buildroot] [PATCH 1/2] package/zmqpp: switch to the official
	git
In-Reply-To: <1426352489-19916-1-git-send-email-romain.naour@openwide.fr>
References: <1426352489-19916-1-git-send-email-romain.naour@openwide.fr>
Message-ID: <20150314214537.GE4009@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Romain, All,

On 2015-03-14 18:01 +0100, Romain Naour spake thusly:
> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
> longer refers to any commit id, even in the previous git tree.
> 
> By reading the Makefile and CHANGELOG.md the last know
> release is 3.2.0.
> 
> Switch to the official git tree and use the 3.2.0 release tag.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Some comment, however...

> ---
>  package/zmqpp/zmqpp.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk
> index fbb0260..7efd04b 100644
> --- a/package/zmqpp/zmqpp.mk
> +++ b/package/zmqpp/zmqpp.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607
> -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION))
> +ZMQPP_VERSION = 3.2.0

3.2.0 is 1.5-year old, and there has been quite some changes in the
repository since then. Would it make sense to use a more recent commit?

Regards,
Yann E. MORIN.

> +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION))
>  ZMQPP_INSTALL_STAGING = YES
>  ZMQPP_DEPENDENCIES = zeromq
>  ZMQPP_LICENSE = LGPLv3+ with exceptions
> -- 
> 1.9.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'