Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4 v5] package/cmake: make ctest a target package too
Date: Sun, 15 Mar 2015 18:41:32 +0100	[thread overview]
Message-ID: <20150315184132.141ba2d9@free-electrons.com> (raw)
In-Reply-To: <1425808043-32292-2-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Sun,  8 Mar 2015 10:47:20 +0100, Samuel Martin wrote:

> diff --git a/package/cmake/Config.in b/package/cmake/Config.in
> new file mode 100644
> index 0000000..3d31d7a
> --- /dev/null
> +++ b/package/cmake/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_CMAKE
> +	bool
> +
> +config BR2_PACKAGE_CMAKE_CTEST
> +	bool "ctest"
> +	select BR2_PACKAGE_CMAKE

There was a missing dependency on C++ (CMake is written entirely in
C++), and also you forgot to 'select' all the libraries you have in
CMAKE_DEPENDENCIES. And one of them, libarchive, has a dependency on
wchar, that had to be propagated here.

Committed with those issues fixed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-03-15 17:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08  9:47 [Buildroot] [PATCH 0/4] CMake package and infra improvements Samuel Martin
2015-03-08  9:47 ` [Buildroot] [PATCH 1/4 v5] package/cmake: make ctest a target package too Samuel Martin
2015-03-08  9:53   ` Baruch Siach
2015-03-08 11:29     ` Samuel Martin
2015-03-15 17:41   ` Thomas Petazzoni [this message]
2015-03-08  9:47 ` [Buildroot] [PATCH 2/4 v2] package/cmake: only build what is necessary Samuel Martin
2015-03-15 17:52   ` Thomas Petazzoni
2015-03-08  9:47 ` [Buildroot] [PATCH 3/4] toolchainfile.cmake: only search the sysroot for CMake module Samuel Martin
2015-03-08 10:23   ` Yegor Yefremov
2015-03-16 21:17   ` Thomas Petazzoni
2015-03-08  9:47 ` [Buildroot] [PATCH 4/4] toolchainfile.cmake: set CXX variables wrt BR2_INSTALL_LIBSTDCPP value Samuel Martin
2015-03-16 21:24   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150315184132.141ba2d9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox