Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/sysdig: New package
Date: Tue, 17 Mar 2015 12:13:05 +0200	[thread overview]
Message-ID: <20150317101305.GL2415@tarshish> (raw)
In-Reply-To: <1426499014-15851-1-git-send-email-angelo.compagnucci@gmail.com>

Hi Angelo,

On Mon, Mar 16, 2015 at 10:43:34AM +0100, Angelo Compagnucci wrote:
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> new file mode 100644
> index 0000000..ff873a8
> --- /dev/null
> +++ b/package/sysdig/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_SYSDIG
> +	bool "sysdig"
> +	depends on BR2_PACKAGE_ZLIB
> +	depends on BR2_PACKAGE_LUAJIT
> +	depends on BR2_PACKAGE_LIBJSON

We generally 'select' packages that are mandatory dependencies, and copy their 
dependencies here. See 
http://nightly.buildroot.org/manual.html#depends-on-vs-select.

> +	depends on BR2_LINUX_KERNEL

This is OK, though. But please also add a comment as described in 
http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2015-03-17 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  9:43 [Buildroot] [PATCH] package/sysdig: New package Angelo Compagnucci
2015-03-17 10:13 ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317101305.GL2415@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox