Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/sysdig: New package
Date: Tue, 17 Mar 2015 13:48:16 +0200	[thread overview]
Message-ID: <20150317114816.GN2415@tarshish> (raw)
In-Reply-To: <CA+TH9VnhBOe+KSV+6nsgF_sUD9SX8WtfQpY2oxG_=5h-=nSniA@mail.gmail.com>

Hi Angelo,

On Tue, Mar 17, 2015 at 12:31:48PM +0100, Angelo Compagnucci wrote:
> 2015-03-17 12:23 GMT+01:00 Baruch Siach <baruch@tkos.co.il>:
> > On Tue, Mar 17, 2015 at 11:56:48AM +0100, Angelo Compagnucci wrote:
> >> +     depends on BR2_LINUX_KERNEL
> >> +     help
> >> +       Sysdig is open source, system-level exploration:
> >> +       capture system state and activity from a running Linux instance,
> >> +       then save, filter and analyze.
> >> +       Think of it as strace + tcpdump + lsof + awesome sauce.
> >> +       With a little Lua cherry on top.
> >> +
> >> +       http://sysdig.org
> >
> > A dependencies comment is still missing here
> > (http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).
> 
> The comment is there:
> 
> @@ -0,0 +1,17 @@
> +comment "sysdig needs a Linux kernel to be built"
> + depends on !BR2_LINUX_KERNEL

You are right, I missed that. It's just that I'm used to see these comments 
below the main 'config' section. Putting the comment above is also fine, 
though. Don't forget to update this comment when adding indirect dependencies.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-03-17 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 10:56 [Buildroot] [PATCH v2] package/sysdig: New package Angelo Compagnucci
2015-03-17 11:23 ` Baruch Siach
2015-03-17 11:31   ` Angelo Compagnucci
2015-03-17 11:48     ` Baruch Siach [this message]
2015-03-17 11:59       ` Angelo Compagnucci
2015-03-17 13:12         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317114816.GN2415@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox