From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] package/avrdude: depends on libftdi1 instead of libftdi
Date: Tue, 17 Mar 2015 17:48:36 +0100 [thread overview]
Message-ID: <20150317174836.6384db5a@free-electrons.com> (raw)
In-Reply-To: <CAHXCMM+52vee+K8p=KOonr=d+F4M7bk-5zWMG2Q2ghmGyWTKLA@mail.gmail.com>
Dear Samuel Martin,
On Tue, 17 Mar 2015 17:24:07 +0100, Samuel Martin wrote:
> Well, my first thought was simply to drop the libftdi support because
> of the additional dependency it pulls (libusb-compat):
> - with dependency on libftdi:
> arvdude -> libftdi -> libusb-compat -> libusb
> - with dependency on libftdi1:
> arvdude -> libftdi1 -> libusb
>
> Note that, the configure script uses libftdi1 (if found) in priority
> over libftdi.
Yes, but what happens if the user has BR2_PACKAGE_AVRDUDE=y and
BR2_PACKAGE_LIBFTDI=y ? Then with your patch, we have an "undefined
behavior": if libftdi happens to be built before avrdude, avrdude will
have libftdi support, otherwise not.
Unless of course you propose a patch that allows to explicitly
enable/disable libftdi support in avrdude. But otherwise, if avrdude
*can* use libftdi, then it should have an optional dependency on it.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-17 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 11:26 [Buildroot] [PATCH v2 0/4] libftdi{0,1} related work Samuel Martin
2015-03-08 11:26 ` [Buildroot] [PATCH v2 1/4] package/libftdi: bump to version 0.20 Samuel Martin
2015-03-16 9:19 ` Thomas Petazzoni
2015-03-08 11:26 ` [Buildroot] [PATCH v2 2/4] package/libftdi1: new package Samuel Martin
2015-03-09 8:33 ` Yegor Yefremov
2015-03-09 10:13 ` Yegor Yefremov
2015-03-09 11:22 ` Yegor Yefremov
2015-03-16 13:12 ` Thomas Petazzoni
2015-03-08 11:26 ` [Buildroot] [PATCH v2 3/4] package/avrdude: depends on libftdi1 instead of libftdi Samuel Martin
2015-03-08 11:48 ` Baruch Siach
2015-03-08 17:03 ` Samuel Martin
2015-03-16 13:15 ` Thomas Petazzoni
2015-03-17 16:24 ` Samuel Martin
2015-03-17 16:48 ` Thomas Petazzoni [this message]
2015-03-17 17:25 ` Samuel Martin
2015-03-17 20:06 ` Thomas Petazzoni
2015-03-17 20:21 ` Samuel Martin
2015-03-08 11:26 ` [Buildroot] [PATCH v2 4/4] package/openocd: " Samuel Martin
2015-03-16 13:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317174836.6384db5a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox