From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/15] avahi: systemd cleanups
Date: Fri, 20 Mar 2015 14:15:46 +0100 [thread overview]
Message-ID: <20150320141546.702ace0c@free-electrons.com> (raw)
In-Reply-To: <1426787807-29510-7-git-send-email-mike@mikebwilliams.com>
Dear Mike Williams,
On Thu, 19 Mar 2015 13:56:38 -0400, Mike Williams wrote:
> +ifneq ($(BR2_PACKAGE_SYSTEMD),y)
> +AVAHI_EXTRA_CFLAGS += -DDISABLE_SYSTEMD
> +endif
This cannot work, since AVAHI_EXTRA_CFLAGS is not used by anything.
I'm surprised you got a Reviewed-by from Samuel and Steven with this
big issue.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-20 13:15 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 17:56 [Buildroot] RFC: systemd and service files cleanup Mike Williams
2015-03-19 17:56 ` [Buildroot] [PATCH 01/15] ntp: move systemd service file to /usr/lib Mike Williams
2015-03-19 19:53 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 02/15] openvmtools: move systemd service " Mike Williams
2015-03-19 19:54 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 03/15] psplash: move systemd service files " Mike Williams
2015-03-19 19:55 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 04/15] openntpd: " Mike Williams
2015-03-19 19:56 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 05/15] dbus: " Mike Williams
2015-03-19 19:56 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 06/15] avahi: systemd cleanups Mike Williams
2015-03-19 19:57 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-20 13:15 ` Thomas Petazzoni [this message]
2015-03-20 13:25 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 07/15] irqbalance: move systemd service file to /usr/lib Mike Williams
2015-03-19 19:58 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 08/15] openssh: move systemd service files " Mike Williams
2015-03-19 19:58 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 09/15] rsyslog: move systemd service file " Mike Williams
2015-03-19 19:59 ` Steven Noonan
2015-03-20 10:28 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 10/15] dropbear: " Mike Williams
2015-03-19 19:59 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 11/15] postgresql: " Mike Williams
2015-03-19 19:59 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 12/15] libiio: " Mike Williams
2015-03-19 20:00 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 13/15] dhcp: " Mike Williams
2015-03-19 20:00 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 14/15] kodi: " Mike Williams
2015-03-19 20:00 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 17:56 ` [Buildroot] [PATCH 15/15] systemd: change install path " Mike Williams
2015-03-19 20:02 ` Steven Noonan
2015-03-20 13:07 ` Samuel Martin
2015-03-19 19:31 ` [Buildroot] RFC: systemd and service files cleanup Steven Noonan
2015-03-19 19:43 ` Mike Williams
2015-03-19 19:50 ` Steven Noonan
2015-03-19 21:44 ` Arnout Vandecappelle
2015-03-20 16:21 ` Mike Williams
2015-03-20 13:18 ` Samuel Martin
2015-03-20 13:20 ` Thomas Petazzoni
2015-03-20 13:27 ` Mike Williams
2015-03-20 13:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320141546.702ace0c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox