From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: add powertop 2.7
Date: Fri, 20 Mar 2015 21:54:58 +0100 [thread overview]
Message-ID: <20150320215458.6a154748@free-electrons.com> (raw)
In-Reply-To: <CAKbGBLiMuNMLZp+7pbPYrS4XZTzge-+gB4a331sCU33yW53BUA@mail.gmail.com>
Dear Steven Noonan,
On Fri, 20 Mar 2015 13:28:03 -0700, Steven Noonan wrote:
> > [Thomas:
> > - fix commit title
> > - powertop wants libintl unconditionally, so make sure
> > BR2_PACKAGE_GETTEXT is selected when BR2_NEEDS_GETTEXT is set,
> > and add gettext to the dependencies.
> > - add missing comment about thread dependency.
> > - add missing dependency on host-pkgconf, without which powertop
> > cannot find libnl.
> > - patch src/Makefile.am to not pass -fstack-protector, which fails
> > to build if the toolchain does not have SSP support.
> > - rename patch powertop-autotune.patch to confirm to the patch
> > naming convention.]
>
> Yes, I agree, that number of issues is ridiculous.
Well, I wouldn't use "ridiculous" : those are your first Buildroot
contributions, so it's kind of expected that you don't necessarily know
all the combinations we typically test before applying patches. I'm
very happy to see new contributors, and to see you and Mike Williams
taking care of the systemd stuff. So clearly I don't want to shoot down
your contributions :-)
> I appreciate the feedback. I had only been testing with x86_64 and x32
> glibc builds, and hadn't thought of uClibc issues. I'll be sure to try
> and test that in the future.
Yes, even though glibc is widely used, uClibc is still our default C
library, and so we continue to check that things build fine with it.
You have some configuration fragments that use pre-built uClibc
toolchains at http://autobuild.buildroot.org/toolchains/configs/, which
make it easy to test various situations without having to rebuild a
full toolchain each time.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-20 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:40 [Buildroot] [PATCH] package: add powertop 2.7 Steven Noonan
2015-03-20 15:33 ` Thomas Petazzoni
2015-03-20 20:28 ` Steven Noonan
2015-03-20 20:54 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-19 3:48 [Buildroot] [PATCH] package: add hwloc 1.10.1 Steven Noonan
2015-03-19 3:48 ` [Buildroot] [PATCH] package: add powertop 2.7 Steven Noonan
2015-03-19 5:31 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320215458.6a154748@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox