Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 05/15] toolchain: remove LARGEFILE selects
Date: Sat, 21 Mar 2015 12:32:03 +0100	[thread overview]
Message-ID: <20150321113203.GB4201@free.fr> (raw)
In-Reply-To: <1426610919-11901-6-git-send-email-gustavo@zacarias.com.ar>

Gustavo, All,

On 2015-03-17 13:48 -0300, Gustavo Zacarias spake thusly:
> There's no need for toolchains or the user to declare largefile support
> since it's now mandatory.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  toolchain/Config.in                    |  2 --
>  toolchain/toolchain-external/Config.in | 14 --------------

You forgot to remove the 'select' from uClibc.

It's done in a future patch, indeed, but I guess it makes sense to
squash it here (just removing the 'select', and having patch 6 gettign
rid of BR2_TOOLCHAIN_BUILDROOT_LARGEFILE).

Regards,
Yann E. MORIN.

>  2 files changed, 16 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index b039ee2..291db94 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -9,7 +9,6 @@ config BR2_TOOLCHAIN
>  # Should be selected for glibc or eglibc
>  config BR2_TOOLCHAIN_USES_GLIBC
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> @@ -24,7 +23,6 @@ config BR2_TOOLCHAIN_USES_UCLIBC
>  
>  config BR2_TOOLCHAIN_USES_MUSL
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index 8b0f09b..3b7f40b 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -635,7 +635,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -655,7 +654,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -782,7 +780,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -800,7 +797,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -818,7 +814,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -885,7 +880,6 @@ config BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_2014_12
>  	depends on BR2_HOSTARCH = "x86_64"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_ENABLE_LOCALE
>  	select BR2_USE_WCHAR
> @@ -1151,14 +1145,6 @@ endchoice
>  
>  if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
>  
> -config BR2_TOOLCHAIN_EXTERNAL_LARGEFILE
> -	bool "Toolchain has large file support?"
> -	select BR2_LARGEFILE
> -	help
> -	  Select this option if your external toolchain supports
> -	  largefile. If you don't know, leave the default value,
> -	  Buildroot will tell you if it's correct or not.
> -
>  config BR2_TOOLCHAIN_EXTERNAL_INET_IPV6
>  	bool "Toolchain has IPv6 support?"
>  	select BR2_INET_IPV6
> -- 
> 2.0.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-03-21 11:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 16:48 [Buildroot] [PATCH v2 00/15] Drop non-largefile support Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 01/15] toolchain/helpers: add check for mandatory uClibc options Gustavo Zacarias
2015-03-21 11:10   ` Yann E. MORIN
2015-03-17 16:48 ` [Buildroot] [PATCH v2 02/15] toolchain/helpers: make LFS mandatory for uclibc toolchains Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 03/15] package/uclibc: default to Y for LARGEFILE Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 04/15] toolchain-common: " Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 05/15] toolchain: remove LARGEFILE selects Gustavo Zacarias
2015-03-21 11:32   ` Yann E. MORIN [this message]
2015-03-17 16:48 ` [Buildroot] [PATCH v2 06/15] package infra: drop non-lfs support Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 07/15] configs: drop largefile option Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 08/15] busybox: force lfs build Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 09/15] system: drop largefile depends Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 10/15] boot/gummiboot: " Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 11/15] packages: remove (non-)lfs dependencies and tweaks Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 12/15] docs/manual: remove references to largefile Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 13/15] packages: remove non-lfs enabler patches Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 14/15] package/uclibc: drop BR2_TOOLCHAIN_BUILDROOT_LARGEFILE Gustavo Zacarias
2015-03-17 16:48 ` [Buildroot] [PATCH v2 15/15] toolchain-common: drop BR2_LARGEFILE Gustavo Zacarias
2015-03-19 21:41 ` [Buildroot] [PATCH v2 00/15] Drop non-largefile support Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150321113203.GB4201@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox