From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] lirc-tools: new package
Date: Sun, 22 Mar 2015 10:19:39 +0200 [thread overview]
Message-ID: <20150322081939.GE2825@tarshish> (raw)
In-Reply-To: <1426933124-1445-1-git-send-email-github@wilberforce.co.nz>
Hi Rhys,
Thanks for reposting your patch. But it seems that you missed all my inline
comments on your patch. Please reread my replay.
Also, when reposting a patch please append a 'v<n>' to the [PATH] prefix, with
<n> being a version number (e.g. v2, v3, etc.). Since you use git, just add
-v2 (or -v3 ...) to your git format-path/send-email.
See one more comment below.
On Sat, Mar 21, 2015 at 11:18:44PM +1300, Rhys Williams wrote:
> Signed-off-by: Rhys Williams <github@wilberforce.co.nz>
> ---
> package/Config.in | 1 +
> package/lirc-tools/Config.in | 15 +++++++++++++++
> package/lirc-tools/S25lircd | 39 +++++++++++++++++++++++++++++++++++++++
> package/lirc-tools/lirc-tools.mk | 30 ++++++++++++++++++++++++++++++
> 4 files changed, 85 insertions(+)
> create mode 100644 package/lirc-tools/Config.in
> create mode 100755 package/lirc-tools/S25lircd
> create mode 100644 package/lirc-tools/lirc-tools.mk
Please also add a .hash file. See
http://nightly.buildroot.org/manual.html#adding-packages-hash.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-03-22 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 10:18 [Buildroot] [PATCH 1/1] lirc-tools: new package Rhys Williams
2015-03-22 8:19 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322081939.GE2825@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox