Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/7 v3] support/download: return different exit codes for different failures
Date: Mon, 23 Mar 2015 19:37:05 +0100	[thread overview]
Message-ID: <20150323183705.GB4214@free.fr> (raw)
In-Reply-To: <CAHXCMMKsdKNtBrDcbXSEOCiBt_NzdcGAC_=G=ROppmJo5y8fCw@mail.gmail.com>

Samuel, All,

On 2015-03-23 14:03 +0100, Samuel Martin spake thusly:
> On Sun, Mar 22, 2015 at 4:21 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > diff --git a/support/download/check-hash b/support/download/check-hash
> > index d0a4ab9..0234ab0 100755
> > --- a/support/download/check-hash
> > +++ b/support/download/check-hash
> > @@ -9,6 +9,15 @@ set -e
> >  #   $3: the final basename of the file, to which it will be ultimately
> >  #       saved as, to be able to match it to the corresponding hashes
> >  #       in the .hash file
> > +#
> > +# Exit codes:
> > +#   0:  the hash file exists and the file to check matches all its hashes,
> > +#       or the hash file does not exist
> > +#   1:  unknown command-line option
> > +#   2:  the hash file exists and the file to check does not match at least
> > +#       of its hashes
> maybe s/of its hashes/one of its hashes/

Yes, good catch! I'll fix before resubmitting.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-03-23 18:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 15:21 [Buildroot] [PATCH 0/7 v3] support/download: be more aggressive on missing hashes (branch yem/dl-hash-2) Yann E. MORIN
2015-03-22 15:21 ` [Buildroot] [PATCH 1/7 v3] support/download: make hash file optional Yann E. MORIN
2015-03-23 12:50   ` Samuel Martin
2015-03-24 19:03   ` Ryan Barnett
2015-03-27 21:31     ` Arnout Vandecappelle
2015-03-22 15:21 ` [Buildroot] [PATCH 2/7 v3] package infra: do not check hashes when downloading from a repository Yann E. MORIN
2015-03-23 12:52   ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 3/7 v3] support/download: add explicit no-hash support Yann E. MORIN
2015-03-22 16:05   ` Arnout Vandecappelle
2015-03-23 12:55     ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 4/7 v3] support/download: return different exit codes for different failures Yann E. MORIN
2015-03-23 13:03   ` Samuel Martin
2015-03-23 18:37     ` Yann E. MORIN [this message]
2015-03-22 15:21 ` [Buildroot] [PATCH 5/7 v3] support/download: properly catch missing hashes Yann E. MORIN
2015-03-23 13:08   ` Samuel Martin
2015-03-22 15:21 ` [Buildroot] [PATCH 6/7 v3] support/download: always fail when there's no hash Yann E. MORIN
2015-03-22 15:21 ` [Buildroot] [PATCH 7/7 v3] support/download: warn when there's no .hash file Yann E. MORIN
2015-03-23 13:10   ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323183705.GB4214@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox