From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/powertop: needs ncursesw
Date: Fri, 27 Mar 2015 17:34:46 +0100 [thread overview]
Message-ID: <20150327173446.779683cf@free-electrons.com> (raw)
In-Reply-To: <1427472097-30708-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Fri, 27 Mar 2015 17:01:36 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/913/913cea22f8a8f5902d8da5f64c3fce056d66790f/
> http://autobuild.buildroot.net/results/6e1/6e11fa2a7405a69c59ced046b92ff08660c4aab7/
> http://autobuild.buildroot.net/results/1d3/1d3323b2afaefa7989854dbccf92015731199e66/
> http://autobuild.buildroot.net/results/1e3/1e31d412d8b3a38a375ad0be8f696bee993ec297/
> http://autobuild.buildroot.net/results/2ff/2ff511eb8d00b94aca68427446e2d0f6e4317a5a/
> and maybe others
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
I am not sure about this patch. I believe there might be a bug in the
powertop configure.ac script. It's doing:
PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"], [
AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], [
AC_MSG_ERROR([ncurses is required but was not found])
], [])
])
So, when using PKG_CHECK_MODULES(), it wants both ncursesw and ncurses.
But if that fails, it tests with AC_SEARCH_LIBS(), but in this case, it
is looking for either ncursesw *or* ncurses.
Am I missing something?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-27 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 16:01 [Buildroot] [PATCH 1/2] package/powertop: needs ncursesw Bernd Kuhls
2015-03-27 16:01 ` [Buildroot] [PATCH 2/2] package/powertop: depends on c++ Bernd Kuhls
2015-03-31 23:06 ` Gustavo Zacarias
2015-04-01 22:07 ` Thomas Petazzoni
2015-03-27 16:34 ` Thomas Petazzoni [this message]
2015-03-27 17:16 ` [Buildroot] [PATCH 1/2] package/powertop: needs ncursesw Bernd Kuhls
2015-03-31 23:03 ` Gustavo Zacarias
2015-04-01 22:07 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327173446.779683cf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox