From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/x11r7/xserver_xorg-server: add --enable-libdrm for udev
Date: Tue, 31 Mar 2015 17:47:02 +0200 [thread overview]
Message-ID: <20150331174702.4c82e8bd@free-electrons.com> (raw)
In-Reply-To: <1427815493-27954-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Tue, 31 Mar 2015 12:24:53 -0300, Gustavo Zacarias wrote:
> If the libdrm package is enabled, the system is built with an udev
> provider and MESA3D_DRI_DRIVER is disabled this adds a --disable-libdrm
> to configure options, but udev still requires libdrm and results in a
> build failure since libdrm include paths aren't filled in (missing drm.h
> include error).
> So add --enable-libdrm for the udev scenario to counteract the previous
> --disable-libdrm.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/x11r7/xserver_xorg-server/xserver_xorg-server.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> index bb5381c..30b7b38 100644
> --- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> +++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> @@ -126,7 +126,7 @@ endif
>
> ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> XSERVER_XORG_SERVER_DEPENDENCIES += udev
> -XSERVER_XORG_SERVER_CONF_OPTS += --enable-config-udev
> +XSERVER_XORG_SERVER_CONF_OPTS += --enable-config-udev --enable-libdrm
Shouldn't this...
> # udev kms support depends on libdrm
> ifeq ($(BR2_PACKAGE_LIBDRM),y)
> XSERVER_XORG_SERVER_DEPENDENCIES += libdrm
be in this if condition, to make sure libdrm is indeed available?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-31 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 15:24 [Buildroot] [PATCH] package/x11r7/xserver_xorg-server: add --enable-libdrm for udev Gustavo Zacarias
2015-03-31 15:47 ` Thomas Petazzoni [this message]
2015-03-31 15:48 ` Gustavo Zacarias
-- strict thread matches above, loose matches on Subject: below --
2015-03-31 15:50 Gustavo Zacarias
2015-03-31 21:42 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331174702.4c82e8bd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox