From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] jamvm: add depends on toolchain w/threads
Date: Wed, 1 Apr 2015 23:43:40 +0200 [thread overview]
Message-ID: <20150401234340.1717eaf2@free-electrons.com> (raw)
In-Reply-To: <1427385280-63133-1-git-send-email-matthew.weber@rockwellcollins.com>
Dear Matt Weber,
On Thu, 26 Mar 2015 10:54:40 -0500, Matt Weber wrote:
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> package/jamvm/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/jamvm/Config.in b/package/jamvm/Config.in
> index f480995..1e33f42 100644
> --- a/package/jamvm/Config.in
> +++ b/package/jamvm/Config.in
> @@ -5,13 +5,15 @@ config BR2_PACKAGE_JAMVM
> || BR2_mips || BR2_mipsel || BR2_powerpc
> select BR2_PACKAGE_ZLIB
> select BR2_PACKAGE_CLASSPATH
> + depends on BR2_TOOLCHAIN_HAS_THREADS
This should have been grouped closer to the BR2_INET_IPV6 dependency.
> help
> JamVM is a new Java Virtual Machine which conforms to the
> JVM specification version 2 (blue book).
>
> http://jamvm.sf.net
>
> -comment "jamvm needs a toolchain w/ IPv6"
> +comment "jamvm needs a toolchain w/ IPv6 and threads"
This should have been "IPv6, threads".
Applied with these minor details fixed.
Also, there's something fishy between jamvm and classpath.
jamvm does select BR2_PACKAGE_CLASSPATH and has classpath in
JAMVM_DEPENDENCIES.
But classpath has depends on BR2_PACKAGE_JAMVM in its Config.in.
Does not make much sense. Peter, you followed the JamVM/Classpath
stuff. What do you think?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-01 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 15:54 [Buildroot] [PATCH 1/1] jamvm: add depends on toolchain w/threads Matt Weber
2015-03-26 18:16 ` Ryan Barnett
2015-03-26 18:52 ` Matthew Weber
2015-04-01 14:28 ` Ryan Barnett
2015-04-01 14:44 ` Thomas Petazzoni
2015-04-01 21:09 ` Matthew Weber
2015-04-01 21:43 ` Thomas Petazzoni [this message]
2015-04-01 21:48 ` Peter Korsgaard
2015-04-01 21:59 ` Thomas Petazzoni
2015-04-02 1:28 ` Matthew Weber
2015-04-02 8:04 ` Peter Korsgaard
2015-04-02 8:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401234340.1717eaf2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox