Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v2] build host lz4 to support lz4 compression in the kernel.
Date: Fri, 3 Apr 2015 00:06:12 +0200	[thread overview]
Message-ID: <20150402220612.GD4229@free.fr> (raw)
In-Reply-To: <20150402000158.0b85c847@free-electrons.com>

Thomas, All,

On 2015-04-02 00:01 +0200, Thomas Petazzoni spake thusly:
> On Wed, 01 Apr 2015 23:55:01 +0200, Arnout Vandecappelle wrote:
> 
> >  Well, I'm in agreement with Johan's earlier statement that the overhead of the
> > host-lz4 build is negligible. It takes 20 seconds on my laptop, of which 6 are
> > buildroot overhead from parsing package/*/*.mk.
> 
> 20 seconds, plus the host-lzop build time that we already build
> unconditionally.
> 
> >  Peter said before that all this hacking of linux (or other) config files should
> > be avoided, and I agree.
> 
> Correct, except when it's related to needed dependencies in Buildroot.
> 
> But if that's fine for everyone, I'm OK with merging an unconditional
> host-lz4 dependency. I'll just follow what the consensus is on this
> matter, since I don't feel like arguing too much on this
> not-so-important issue.
> 
> Thanks for the feedback, definitely very useful to have the opinion of
> others to help take a decision.

Well, I always find it very frustrating to build something that I do not
use. 20 seconds is an eternity (even the 15-or-so it takes here).

Also, I see a lot of people doing this use-case, and being quite
frustrated:

    make foo_defconfig
    make linux-menuconfig
    [Bam, 20s overhead, 35s on slower machines]

Otherwise, 15s for a lzo, yet another 10s for lz4. What next?

I would side with Thomas: add an entry in the Buildroot menuconfig to
configure what compression to use.

My 2-cent advice... ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-04-02 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 20:12 [Buildroot] [PATCH 1/1 v2] build host lz4 to support lz4 compression in the kernel Sagaert Johan
2015-04-01 20:37 ` Thomas Petazzoni
2015-04-01 21:55   ` Arnout Vandecappelle
2015-04-01 22:01     ` Thomas Petazzoni
2015-04-02 22:06       ` Yann E. MORIN [this message]
2015-04-02 23:35         ` Johan Sagaert
2015-04-04 22:51         ` Johan Sagaert
2015-04-05  9:12           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402220612.GD4229@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox