From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Fri, 3 Apr 2015 08:00:43 +0300 Subject: [Buildroot] [PATCH 1/1] miraclecast: new package In-Reply-To: <1428030634-23928-1-git-send-email-ryanbarnett3@gmail.com> References: <1428030634-23928-1-git-send-email-ryanbarnett3@gmail.com> Message-ID: <20150403050043.GM17056@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Ryan, On Thu, Apr 02, 2015 at 10:10:34PM -0500, Ryan Barnett wrote: > diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk > index 98bda02..a94ce04 100644 > --- a/package/systemd/systemd.mk > +++ b/package/systemd/systemd.mk > @@ -77,6 +77,11 @@ else > SYSTEMD_CONF_OPTS += --disable-seccomp > endif > > +ifeq ($(BR2_PACKAGE_MIRACLECAST),y) > +# Must enable kdbus in order to get sd-events.h in staging > +SYSTEMD_CONF_OPTS += --enable-kdbus > +endif This looks somewhat unusual. And besides, kdbus should be a useful feature on its own right. So why not add a BR2_PACKAGE_SYSTEMD_KDBUS option, and have BR2_PACKAGE_MIRACLECAST select that? Setting the right kernel dependency for BR2_PACKAGE_SYSTEMD_KDBUS would be an interesting question, though. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -