From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/softether: Fix build error on ARC
Date: Fri, 3 Apr 2015 14:04:51 +0200 [thread overview]
Message-ID: <20150403140451.3dba6a5f@free-electrons.com> (raw)
In-Reply-To: <1428004759-25894-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Thu, 2 Apr 2015 21:59:18 +0200, Bernd Kuhls wrote:
> +--- a/src/Mayaqua/Mayaqua.h.org 2015-04-02 21:52:44.911083674 +0200
> ++++ b/src/Mayaqua/Mayaqua.h 2015-04-02 21:51:52.075081069 +0200
> +@@ -235,9 +235,11 @@
> + #ifdef OS_UNIX
> + #ifndef UNIX_SOLARIS
> + #ifndef CPU_SH4
> ++#ifndef __arc__
This is not the correct fix. The fact that the toolchain used in the
build tests that failed does not have ifaddrs support is completely
unrelated to the fact that it's an ARC toolchain.
It's simply because this specific toolchain is an external toolchain
that doesn't have the ifaddrs support. The internal ARC toolchain will
have ifaddrs support, and other external toolchains may not have it.
So the right fix is to actually test whether ifaddrs support is
available or not. I've pushed a fix that implements this (hopefully
correctly) :
http://git.buildroot.net/buildroot/commit/?id=d9cf0a76db5e428692f2489901c9787b1fd30eee
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-04-03 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 19:59 [Buildroot] [PATCH 1/2] package/softether: Fix build error on ARC Bernd Kuhls
2015-04-02 19:59 ` [Buildroot] [PATCH 2/2] package/softether: bump version Bernd Kuhls
2015-04-03 12:07 ` Thomas Petazzoni
2015-04-02 21:10 ` [Buildroot] [PATCH 1/2] package/softether: Fix build error on ARC Peter Korsgaard
2015-04-03 12:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403140451.3dba6a5f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox