Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add package sl
Date: Fri, 3 Apr 2015 16:31:49 +0200	[thread overview]
Message-ID: <20150403163149.42547bc6@free-electrons.com> (raw)
In-Reply-To: <1427879325-12015-1-git-send-email-j.rosenboom@x-ion.de>

Dear Jens Rosenboom,

On Wed,  1 Apr 2015 11:08:45 +0200, Jens Rosenboom wrote:
> SL (Steam Locomotive) runs across your terminal when you type "sl" as
> you meant to type "ls". It's just a joke command, and not useful at all.
> 
> Might want to depend on BR2_PACKAGE_NCURSES_WCHAR even in order to get
> terminfo for xterm-256color, but I'm not sure whether that should be
> just optional.
> 
> Signed-off-by: Jens Rosenboom <j.rosenboom@x-ion.de>
> ---
>  package/Config.in    |  1 +
>  package/sl/Config.in |  9 +++++++++
>  package/sl/sl.mk     | 20 ++++++++++++++++++++
>  3 files changed, 30 insertions(+)
>  create mode 100644 package/sl/Config.in
>  create mode 100644 package/sl/sl.mk

Thanks, applied, after doing a number of changes:

    [Thomas:
     - Change "depends on BR2_PACKAGE_NCURSES" to "select
       BR2_PACKAGE_NCURSES".
     - Rewrap Config.in help text.
     - Remove comment in help text about the need to check dependencies,
       there's nothing to be done really.
     - Change the license from "Unclear" to "Custom".
     - Use $(TARGET_CONFIGURE_OPTS instead of passing CC and CFLAGS
       explicitly.
     - Pass '-m 0755' when doing the $(INSTALL)
     - Add ncurses to SL_DEPENDENCIES.]

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-04-03 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  9:08 [Buildroot] [PATCH 1/1] Add package sl Jens Rosenboom
2015-04-01  9:26 ` Angelo Compagnucci
2015-04-01 21:12   ` Arnout Vandecappelle
2015-04-03 16:42     ` Angelo Compagnucci
2015-04-03 14:31 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403163149.42547bc6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox