Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5 v2] package infra: add patch-dependencies
Date: Sat, 4 Apr 2015 15:47:05 +0200	[thread overview]
Message-ID: <20150404154705.4be3e45d@free-electrons.com> (raw)
In-Reply-To: <a51d416e81f55374ba749baa81222bfe0c52782b.1426342904.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Sat, 14 Mar 2015 15:25:17 +0100, Yann E. MORIN wrote:

> -$(1)-show-depends:
> +$(1)-show-build-depends:
>  			@echo $$($(2)_FINAL_DEPENDENCIES)
> +$(1)-show-patch-depends:
> +			@echo $$($(2)_FINAL_PATCH_DEPENDENCIES)
> +$(1)-show-depends:
> +			@echo $$(sort $$($(2)_FINAL_DEPENDENCIES) $$($(2)_FINAL_PATCH_DEPENDENCIES))

I think this will break graph-depends. The python script will do "make
<foo>-show-depends" for each package. Now this will return things such
as "xenomai-patch", so the script will then try to do "make
xenomai-patch-show-depends" to recurse into the dependency tree, and
this will fail. <pkg>-show-depends should only return the name of
packages.

Also, I'm not sure about the usefulness of having separate
show-build-depends and show-patch-depends. It could have been useful if
show-depends would simply depend on them, but it doesn't work because
we want all dependencies space-separated on one line.

So, what about replacing this part with just:

$(1)-show-depends:
	@echo $$(sort $$($(2)_FINAL_DEPENDENCIES) $$(patsubst %-patch,%,$$($(2)_FINAL_PATCH_DEPENDENCIES)))

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-04-04 13:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14 14:25 [Buildroot] [PATCH 0/5 v2] linux: fix using extensions (branch yem/kernel-ext) Yann E. MORIN
2015-03-14 14:25 ` [Buildroot] [PATCH 1/5 v2] package infra: add patch-dependencies Yann E. MORIN
2015-03-24 23:22   ` Romain Naour
2015-04-04 13:47   ` Thomas Petazzoni [this message]
2015-04-05  9:16     ` Yann E. MORIN
2015-04-05  9:46       ` Thomas Petazzoni
2015-04-14  0:17   ` Arnout Vandecappelle
2015-03-14 14:25 ` [Buildroot] [PATCH 2/5 v2] docs/manual: add _PATCH_DEPENDENCIES Yann E. MORIN
2015-03-24 23:22   ` Romain Naour
2015-03-14 14:25 ` [Buildroot] [PATCH 3/5 v2] linux: fix extensions Yann E. MORIN
2015-03-24 23:22   ` Romain Naour
2015-03-14 14:25 ` [Buildroot] [PATCH 4/5 v2] linux: simplify adding new extensions Yann E. MORIN
2015-03-26 21:54   ` Romain Naour
2015-03-14 14:25 ` [Buildroot] [PATCH 5/5 v2] linux: migrate extensions to use the new infrastructure Yann E. MORIN
2015-03-26 21:55   ` Romain Naour
2015-04-09 21:11 ` [Buildroot] [PATCH 0/5 v2] linux: fix using extensions (branch yem/kernel-ext) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150404154705.4be3e45d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox