From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Sun, 5 Apr 2015 18:34:54 +0300 Subject: [Buildroot] [PATCH] lirc-tools: fix build with host python3 In-Reply-To: <20150405172857.7b773e82@free-electrons.com> References: <20150405172857.7b773e82@free-electrons.com> Message-ID: <20150405153454.GA2183@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Thomas, On Sun, Apr 05, 2015 at 05:28:57PM +0200, Thomas Petazzoni wrote: > On Sun, 5 Apr 2015 18:26:06 +0300, Baruch Siach wrote: > > Add an upstream patch making make_rel_symlink.py python3 compatible and making > > python3 mandatory. Update lirc-tools dependencies accordingly. > > > > Fixes: > > http://autobuild.buildroot.net/results/6c6/6c6e014a751650c16d25dfd3d673bd3199c72b2e/ > > http://autobuild.buildroot.net/results/857/85724dfd014cec5a80dd18a635826daa2edc1417/ > > http://autobuild.buildroot.net/results/a74/a74563f700a47065ffd1ba42c83c2d7722bacd89/ > > > > and many others. > > > > Signed-off-by: Baruch Siach > > Is host-python3 actually mandatory? When BR2_PACKAGE_PYTHON3 is not > enabled, it can perfectly fine use the host python? > > So what about: > > * Using #!/usr/bin/env python in the script, and make the script both > python 2 and python 3 compliant. > > * Use $(if $(BR2_PACKAGE_PYTHON3),host-python3) in the dependencies ? Are both needed? If the script is compliant with both python2 and python3, then we can rely on the host provided python in case host-python3 has not been built by the time lirc-tools builds, isn't it? baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -