Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] systemd: add option to enable kdbus support
Date: Mon, 6 Apr 2015 08:04:22 +0300	[thread overview]
Message-ID: <20150406050422.GD2183@tarshish> (raw)
In-Reply-To: <1428271811-27530-1-git-send-email-ryanbarnett3@gmail.com>

Hi Ryan,

On Sun, Apr 05, 2015 at 05:10:10PM -0500, Ryan Barnett wrote:
> In the future when the kernel offically supports kdbus, this option
> should automatically enable the kernel kdbus config option(s).

So there is no need to fiddle with kernel version dependency for 
--enable-kdbus?

[...]

> +ifeq ($(BR2_PACKAGE_SYSTEMD_KDBUS),y)
> +SYSTEMD_CONF_OPTS += --enable-kdbus
> +else
> +SYSTEMD_CONF_OPTS += --disable-kdbus
> +endif

Is there any reason not to enable kdbus when the kernel supports that? If not, 
I'd suggest to add --enable-kdbus unconditionally, and remove 
BR2_PACKAGE_SYSTEMD_KDBUS.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2015-04-06  5:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05 22:10 [Buildroot] [PATCH v2 1/2] systemd: add option to enable kdbus support Ryan Barnett
2015-04-05 22:10 ` [Buildroot] [PATCH v2 2/2] miraclecast: new package Ryan Barnett
2015-11-30 22:26   ` Thomas Petazzoni
2015-04-06  5:04 ` Baruch Siach [this message]
2015-04-08  3:15   ` [Buildroot] [PATCH v2 1/2] systemd: add option to enable kdbus support Ryan Barnett
2015-04-21 13:52     ` Mike Williams
2015-07-13 15:36 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150406050422.GD2183@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox