From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/raspberrypi: remove BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
Date: Tue, 7 Apr 2015 19:01:26 +0200 [thread overview]
Message-ID: <20150407170126.GA4216@free.fr> (raw)
In-Reply-To: <4c57acb52a45749057a0ca92d1d982a78c6f8cc2.1428401645.git.baruch@tkos.co.il>
Baruch, All,
On 2015-04-07 13:14 +0300, Baruch Siach spake thusly:
> BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS became ineffective in commit a5ce7590c4b
> (package/rpi-firmware: bump version), and was removed in commit 4e92ffdc47cc
> (rpi-firmware: remove no longer used BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS).
> Remove it from the Pi configs.
>
> Also, remove the now obsolete comment in these config files.
>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
I basically agree on the change.
However, this means there is now no reason to have separate sdefconfig
files for the RPi (version 1) as both now use a DTB.
So, we should now:
- get rid of configs/raspberrypi_defconfig
- rename configs/raspberrypi_dt_defconfig into configs/raspberrypi_defconfig
Otherwise, looks fine.
Regards,
Yann E. MORIN.
> ---
> configs/raspberrypi2_defconfig | 2 --
> configs/raspberrypi_dt_defconfig | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/configs/raspberrypi2_defconfig b/configs/raspberrypi2_defconfig
> index 4d4944f9e3f1..814e1820e8d1 100644
> --- a/configs/raspberrypi2_defconfig
> +++ b/configs/raspberrypi2_defconfig
> @@ -19,6 +19,4 @@ BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="23c76b7f608e51258c6fca02aebeb5d588583149"
> BR2_LINUX_KERNEL_DEFCONFIG="bcm2709"
> BR2_LINUX_KERNEL_ZIMAGE=y
>
> -# Install the DTB files, as the RPi2 uses the Device Tree
> BR2_PACKAGE_RPI_FIRMWARE=y
> -BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y
> diff --git a/configs/raspberrypi_dt_defconfig b/configs/raspberrypi_dt_defconfig
> index ca62084c4d9c..c727a7cdfd1f 100644
> --- a/configs/raspberrypi_dt_defconfig
> +++ b/configs/raspberrypi_dt_defconfig
> @@ -17,6 +17,4 @@ BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/raspberrypi/linux-3.18-rpi-dt.defconfig"
> BR2_LINUX_KERNEL_ZIMAGE=y
>
> -# Install the DTB files
> BR2_PACKAGE_RPI_FIRMWARE=y
> -BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y
> --
> 2.1.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-07 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 10:14 [Buildroot] [PATCH] configs/raspberrypi: remove BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS Baruch Siach
2015-04-07 17:01 ` Yann E. MORIN [this message]
2015-04-07 17:05 ` Yann E. MORIN
2015-04-07 17:34 ` Baruch Siach
2015-04-07 19:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407170126.GA4216@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox