Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/uclibc: libm: Add missing C99 float/ld wrappers (backport)
Date: Tue, 7 Apr 2015 22:36:35 +0200	[thread overview]
Message-ID: <20150407223635.04679618@free-electrons.com> (raw)
In-Reply-To: <20150329135608.38d08f5e@free-electrons.com>

Bernd,

Could you get back to me about the below comments, ideally with a new
iteration of the patches?

Thanks a lot!

Thomas

On Sun, 29 Mar 2015 13:56:08 +0200, Thomas Petazzoni wrote:
> Dear Bernd Kuhls,
> 
> On Sun, 29 Mar 2015 01:29:07 +0100, Bernd Kuhls wrote:
> > This commit adds a patch to uclibc with a backport from upstream
> > to provide a proper fix for mesa3d which depends on fminf.
> > Also remove the mesa3d patch which provided a crappy workaround.
> > 
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> >  .../0002-Fix-runtime-error-with-uClibc.patch       |   58 --
> >  .../0069-Add-missing-C99-float-ld-wrappers.patch   |  870 ++++++++++++++++++++
> >  2 files changed, 870 insertions(+), 58 deletions(-)
> >  delete mode 100644 package/mesa3d/0002-Fix-runtime-error-with-uClibc.patch
> >  create mode 100644 package/uclibc/0.9.33.2/0069-Add-missing-C99-float-ld-wrappers.patch
> 
> I think we might need to keep the crappy workaround, or an improved
> version of it. The problem with doing a uClibc patch is that it will
> only work with internal uClibc toolchains: all uClibc toolchains will
> continue to be broken.
> 
> So we might want to do both:
> 
>  1/ Fix uClibc properly, so that in the future (3-6 months from now),
>  we can get rid of the mesa3d specific fix, after most of the external
>  uClibc toolchains have been updated.
> 
>  2/ Keep a mesa3d workaround for a little while.
> 
> Thomas



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-04-07 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-29  0:29 [Buildroot] [PATCH 1/2] package/uclibc: libm: Add missing C99 float/ld wrappers (backport) Bernd Kuhls
2015-03-29  0:29 ` [Buildroot] [PATCH 2/2] package/{mesa3d, mesa3d-headers}: bump version to 10.5.2 Bernd Kuhls
2015-03-29 11:56 ` [Buildroot] [PATCH 1/2] package/uclibc: libm: Add missing C99 float/ld wrappers (backport) Thomas Petazzoni
2015-04-07 20:36   ` Thomas Petazzoni [this message]
2015-04-13  5:50     ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407223635.04679618@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox