Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] doxygen: new package
Date: Fri, 10 Apr 2015 11:23:26 +0200	[thread overview]
Message-ID: <20150410112326.53cb8726@free-electrons.com> (raw)
In-Reply-To: <CAMpxmJU_wsEqkm0UPA2eMGVcts3giLLdAxyKLR=0KRjyLMJqcw@mail.gmail.com>

Dear Bartosz Golaszewski,

On Fri, 10 Apr 2015 11:20:52 +0200, Bartosz Golaszewski wrote:

> Sorry, for that - I eventually forgot to change host-autotools-package
> to host-generic-package. Surprisingly it works.

This is not surprising: host-autotools-package allows you to override
<pkg>_CONFIGURE_CMDS, <pkg>_BUILD_CMDS and <pkg>_INSTALL_*_CMDS.

Also, in your v3, remove the parenthesis:

	($(MAKE) -C $(@D))

should be just:

	$(MAKE) -C $(@D)

And add a comment in the .mk file to explain why we're not using
host-autotools-package even if there is a ./configure script being
called.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-04-10  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  8:16 [Buildroot] [PATCH v2 0/3] fix pulseview build failures Bartosz Golaszewski
2015-04-10  8:16 ` [Buildroot] [PATCH v2 1/3] doxygen: new package Bartosz Golaszewski
2015-04-10  9:20   ` Bartosz Golaszewski
2015-04-10  9:23     ` Thomas Petazzoni [this message]
2015-04-10  8:16 ` [Buildroot] [PATCH v2 2/3] libsigrok: add host-doxygen dependency for C++ bindings Bartosz Golaszewski
2015-04-10  8:16 ` [Buildroot] [PATCH v2 3/3] Revert "libsigrok: mark libsigrokcxx as broken" Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410112326.53cb8726@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox