Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] Move host-pkgconf dependency to package/pkg-autotools.mk
Date: Fri, 10 Apr 2015 14:12:17 +0200	[thread overview]
Message-ID: <20150410141217.4bd2547c@free-electrons.com> (raw)
In-Reply-To: <XnsA4787599FCF1BberndkuhlsPkbjNfxxIA@bernd-kuhls.de>

Dear Bernd Kuhls,

On Fri, 10 Apr 2015 11:33:39 +0200, Bernd Kuhls wrote:
> Hi,
> 
> is there a reason an autotools-package should not depend on host-pkgconf?
> 
> The phrase "host-pkgconf" appears in > 300 packages
> 
> $ for i in `find -iname *.mk | grep -v pkgconf`; do grep host-pkgconf $i; 
> done | wc -l
> 313
> 
> If 
> 
> $(2)_DEPENDENCIES += host-pkgconf
> 
> is added to package/pkg-autotools.mk we could get rid of all those 
> dependencies in the packages and avoid nasty build errors in the future.

I think it has been discussed in the past, even though I don't remember
the conclusion. On my side, since I don't like useless dependencies,
but I recognize that we often forget to add host-pkgconf in the
dependencies of a number of autotools packages, I made a proposal last
year: http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/82327.

It checks before building if the package uses PKG_CHECK_MODULES(), and
verifies that the package properly depends on host-pkgconf in this case.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-04-10 12:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  9:33 [Buildroot] [RFC] Move host-pkgconf dependency to package/pkg-autotools.mk Bernd Kuhls
2015-04-10 10:52 ` Bernd Kuhls
2015-04-10 12:09   ` Thomas Petazzoni
2015-04-10 12:12 ` Thomas Petazzoni [this message]
2015-04-10 21:31   ` Arnout Vandecappelle
2015-04-11  7:47     ` Thomas Petazzoni
2015-04-21 14:13       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410141217.4bd2547c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox