From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU
Date: Sat, 11 Apr 2015 20:24:07 +0200 [thread overview]
Message-ID: <20150411202407.2fd37afb@free-electrons.com> (raw)
In-Reply-To: <1428702305-28208-1-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Fri, 10 Apr 2015 23:45:05 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> .../0001-gdbserver-fix-uClibc-whithout-MMU.patch | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
>
> diff --git a/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
> new file mode 100644
> index 0000000..23486a3
> --- /dev/null
> +++ b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
> @@ -0,0 +1,38 @@
> +From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
> +From: Romain Naour <romain.naour@openwide.fr>
> +Date: Fri, 10 Apr 2015 22:58:07 +0200
> +Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
> +
> +Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
> +must be retrieved from current_thread.
> +
> +The change has not been made in the function linux_read_offsets().
> +
> +Fixes:
> +http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
> +
> +Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> +
> +Conflicts:
> + gdb/gdbserver/linux-low.c
This Conflicts info is probably not needed.
> +---
> + gdb/gdbserver/linux-low.c | 3 ++-
> + 1 file changed, 2 insertions(+), 1 deletion(-)
> +
> +diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> +index 4d19c87..23f012d 100644
> +--- a/gdb/gdbserver/linux-low.c
> ++++ b/gdb/gdbserver/linux-low.c
> +@@ -4933,7 +4933,8 @@ static int
> + linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
> + {
> + unsigned long text, text_end, data;
> +- int pid = lwpid_of (get_thread_lwp (current_thread));
> ++
No need to add this empty line here.
> ++ int pid = lwpid_of (current_thread);
Can you respin a new version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-11 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 21:45 [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU Romain Naour
2015-04-11 18:24 ` Thomas Petazzoni [this message]
2015-04-12 12:52 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150411202407.2fd37afb@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox