[Buildroot] [PATCH] giflib: fix description about compatibility with libungif

[Baruch Siach <baruch@tkos.co.il>]

Hi Fabio,

On Sun, Apr 12, 2015 at 10:57:40AM +0200, Fabio Porcedda wrote:
> On Sun, Apr 12, 2015 at 10:47 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > On Sun, Apr 12, 2015 at 10:43:05AM +0200, Fabio Porcedda wrote:
> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >> ---
> >>  package/giflib/Config.in | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/package/giflib/Config.in b/package/giflib/Config.in
> >> index 70368dc..bb5741a 100644
> >> --- a/package/giflib/Config.in
> >> +++ b/package/giflib/Config.in
> >> @@ -1,7 +1,7 @@
> >>  config BR2_PACKAGE_GIFLIB
> >>       bool "giflib"
> >>       help
> >> -       giflib is a library for reading and writing gif images. It is API and
> >> +       giflib is a library for reading and writing gif images. It was API and
> >>         ABI compatible with libungif which was in wide use while the LZW
> >>         compression algorithm was patented.
> >
> > So giflib is not compatible to libungif anymore?
> 
> Just comparing the gif_lib.h header you can see that the definition of
> some functions changes:
> 
> git diff --no-index libungif-4.1.4/lib/gif_lib.h giflib-5.1.1/lib/gif_lib.h
> 
>  GifFileType *EGifOpenFileName(const char *GifFileName,
> -                              int GifTestExistance);
> -GifFileType *EGifOpenFileHandle(int GifFileHandle);
> -GifFileType *EGifOpen(void *userPtr, OutputFunc writeFunc);
> -
> +                              const bool GifTestExistence, int *Error);
> +GifFileType *EGifOpenFileHandle(const int GifFileHandle, int *Error);
> +GifFileType *EGifOpen(void *userPtr, OutputFunc writeFunc, int *Error);
>  int EGifSpew(GifFileType * GifFile);

If this is the case I would use a more explicit language. Something like:

	giflib used to be API and ABI compatible with libungif which ... Note that 
	recent gitlib versions are no longer compatible with libungif.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -