From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros
Date: Mon, 13 Apr 2015 21:53:17 +0200 [thread overview]
Message-ID: <20150413195317.GD29025@free.fr> (raw)
In-Reply-To: <1428918801-19631-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2015-04-13 11:53 +0200, Thomas Petazzoni spake thusly:
> The package infrastructure macros have a long time ago been renamed
> from GENTARGETS, AUTOTARGETS to generic-package and
> autotools-package. However, one comment in pkg-utils.mk keeps a
> reference to these *TARGETS macros. This commit updates this comment
> to match the new name of these macros.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
I was puzzled as to why I could still see 'TARGETS' even after your
series was applied. This squashes that concenr of mine on your series. ;-)
Regards,
Yann E. MORIN.
> ---
> package/pkg-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 7eddc47..5a385f8 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -60,7 +60,7 @@ endef
>
> # Helper functions to determine the name of a package and its
> # directory from its makefile directory, using the $(MAKEFILE_LIST)
> -# variable provided by make. This is used by the *TARGETS macros to
> +# variable provided by make. This is used by the *-package macros to
> # automagically find where the package is located.
> pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
> pkgname = $(lastword $(subst /, ,$(pkgdir)))
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-13 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 9:53 [Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros Thomas Petazzoni
2015-04-13 19:53 ` Yann E. MORIN [this message]
2015-04-13 20:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413195317.GD29025@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox