Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] json-c: bump version to json-c-0.12-20140410
Date: Tue, 14 Apr 2015 12:15:02 +0300	[thread overview]
Message-ID: <20150414091501.GQ2279@tarshish> (raw)
In-Reply-To: <1429002618-22546-1-git-send-email-sagaert.johan@proximus.be>

Hi Sagaert Johan,

On Tue, Apr 14, 2015 at 11:10:18AM +0200, Sagaert Johan wrote:
> diff --git a/package/json-c/0001-remove-unused-assignment.patch b/package/json-c/0001-remove-unused-assignment.patch
> new file mode 100644
> index 0000000..369e89f
> --- /dev/null
> +++ b/package/json-c/0001-remove-unused-assignment.patch
> @@ -0,0 +1,30 @@
> +From 35087bf7775481fbb880d38cde03ea654474dfa1 Mon Sep 17 00:00:00 2001
> +From: Sagaert Johan <sagaert.johan@proximus.be>
> +Date: Tue, 14 Apr 2015 10:43:05 +0200
> +Subject: [PATCH 1/1] remove unused asignment
> +
> +Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>
> +---
> + json_tokener.c | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/json_tokener.c b/json_tokener.c
> +index 19de8ef..9a76293 100644
> +--- a/json_tokener.c
> ++++ b/json_tokener.c
> +@@ -352,12 +352,10 @@ struct json_object* json_tokener_parse_ex(struct json_tokener *tok,
> + 
> +     case json_tokener_state_inf: /* aka starts with 'i' */
> +       {
> +-	int size;
> + 	int size_inf;
> + 	int is_negative = 0;
> + 
> + 	printbuf_memappend_fast(tok->pb, &c, 1);
> +-	size = json_min(tok->st_pos+1, json_null_str_len);
> + 	size_inf = json_min(tok->st_pos+1, json_inf_str_len);
> + 	char *infbuf = tok->pb->buf;
> + 	if (*infbuf == '-')

It seems this packages builds with -Werror, hence the need for this patch to 
avoid build breakage. A better solution, in my opinion, is to remove -Werror.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-04-14  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  9:10 [Buildroot] [PATCH 1/1] json-c: bump version to json-c-0.12-20140410 Sagaert Johan
2015-04-14  9:15 ` Baruch Siach [this message]
2015-04-14 23:21   ` Johan Sagaert
2015-04-15  3:13     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150414091501.GQ2279@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox