Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/2] python-pyqt: new package
Date: Sun, 19 Apr 2015 19:23:45 +0200	[thread overview]
Message-ID: <20150419192345.3ec38d2a@free-electrons.com> (raw)
In-Reply-To: <1429430633-12267-2-git-send-email-gwenj@trabucayre.com>

Gwenhael,

On Sun, 19 Apr 2015 10:03:53 +0200, Gwenhael Goavec-Merou wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> Cc: Sergey Kostanbaev <sergey.kostanbaev@gmail.com>

Patch applied, after doing some additional changes:

    [Thomas:
     - Remove dependency on python (already a dependency of python-sip),
       and add a dependency on host-python-sip, since python-sip no longer
       depends on host-python-sip.
     - Make the code Python 2 / Python 3 compatible (both have been
       tested).
     - Fix indentation all over the place.
     - Remove double quotes when defining variable values, not needed.
     - Add <pkg>_BUILD_CMDS to do the build process separately from the
       installation.
     - Create a PYTHON_PYQT_CONF_OPTS variable with all the config
       options, since some of them are now conditional.
     - Use 'compileall' to byte-compile the dummy __init__.py.]

I also made a fix on python-sip to make things build properly on Python 3.

I tested PyQt with both Python 2 and Python 3, and I was able to run:

>>> from PyQt4 import QtCore
>>> QtCore.QDateTime.currentDateTime()
PyQt4.QtCore.QDateTime(2015, 4, 19, 16, 59, 12, 794)

in both cases. Don't hesitate to test with bigger applications to
confirm that everything is still working fine.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-04-19 17:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19  8:03 [Buildroot] [PATCH v3 1/2] python-sip: new package Gwenhael Goavec-Merou
2015-04-19  8:03 ` [Buildroot] [PATCH v3 2/2] python-pyqt: " Gwenhael Goavec-Merou
2015-04-19 17:23   ` Thomas Petazzoni [this message]
2015-04-20  7:34     ` gwenhael.goavec
2015-04-19 13:02 ` [Buildroot] [PATCH v3 1/2] python-sip: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150419192345.3ec38d2a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox