From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Wed, 22 Apr 2015 18:29:36 +0200 Subject: [Buildroot] [PATCH 2/3] manual: cvs: document that a date can be used instead of a tag In-Reply-To: References: <1429376067-9228-1-git-send-email-fabio.porcedda@gmail.com> <1429376067-9228-3-git-send-email-fabio.porcedda@gmail.com> <20150419081028.GB4313@free.fr> <5533CD7D.1070605@mind.be> <55356A45.5020301@mind.be> Message-ID: <20150422162936.GA4069@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Fabio, Gustavo, All, On 2015-04-22 10:03 +0200, Fabio Porcedda spake thusly: > On Mon, Apr 20, 2015 at 11:06 PM, Arnout Vandecappelle wrote: > > On 20/04/15 04:36, Fabio Porcedda wrote: [--SNIP--] > >> This one works: (--
[T:[:][-] e.g > >> 2015-12-20 or 2015-12-20T10:10-00) > > > > Well, the example should include a timezone and mention that adding a timezone > > is advisable. > Ok. > > > Alternatively, we could specifies that times are in UTC and set TZ=UTC in the > > cvs helper. > > Fine for me. > Yann what do you think about it? I don't care. But what if a user specifies a timezone? The tricky part with dealing with date (aka human date and timei) is exactly that: having to deal with it. It is very complex to parse a date in a reliable manner. So we can't really validate a date. I'd rather we allow the full range of dates supported by cvs, and let it deal with whatever the user provides, and if that's incorrect, let cvs fail, not us (well, we'd eventually fail, but not on our will). > >> But to made it works I must replace the ":" with "_": > > > > Why? The / substitution is only needed because VERSION is used in filenames, > > and : is fine in filenames, no? > > The colon is fine for filenames, neverthless if i don't replace it, I > get this error: > > $ make expect-source > package/expect/expect.mk:19: *** target pattern contains no '%'. Stop. Yes, because the $(@D) contains the version string, and it is a make goal. So, we'd end up wth something like; foo-2015-04-22T18:26/.stamp_extracted: blabla Notice that there are two columns, and that is not valid make syntax (AFAIR). Which make me think: "2015-04-22 18:26" is an equally valid date, and we do not really support spaces in paths, so we'd have to also replaces spaces as well. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'