From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Wed, 22 Apr 2015 23:58:33 +0200 Subject: [Buildroot] [PATCH] pkg-cmake: Skip compilation in installation step In-Reply-To: <1429733516-4466-1-git-send-email-cedric.marie@openmailbox.org> References: <1429733516-4466-1-git-send-email-cedric.marie@openmailbox.org> Message-ID: <20150422215833.GE4069@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net C?dric, All, On 2015-04-22 22:11 +0200, C?dric Marie spake thusly: > With CMake build system, the "make install" command always compiles > before installing, to make sure that everything is up-to-date. > > In Buildroot environment, this is quite useless, because the package > has always already been compiled, either at first build, or when > invoking "make -rebuild". > In all cases, when it comes to staging or target installation step, the > package has just been compiled. > > Using "make install/fast" - in order to skip the compilation step - is > therefore more appropriate, more consistent with what other build > systems do, and saves time when you need to rebuild your package. > > Signed-off-by: C?dric Marie > --- > package/pkg-cmake.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk > index 2262012..f17a883 100644 > --- a/package/pkg-cmake.mk > +++ b/package/pkg-cmake.mk > @@ -57,8 +57,8 @@ $(2)_MAKE ?= $$(MAKE) > $(2)_MAKE_ENV ?= > $(2)_MAKE_OPTS ?= > $(2)_INSTALL_OPTS ?= install > -$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install > -$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install > +$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install/fast > +$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install/fast Would it also make sense we install cmake itself with this rule, in package/cmake/cmake.mk:47 , too? Regards, Yann E. MORIN. > $(2)_SRCDIR = $$($(2)_DIR)/$$($(2)_SUBDIR) > > -- > 2.1.4 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'