From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mosquitto: remove ipv6 depends
Date: Thu, 23 Apr 2015 00:20:33 +0200 [thread overview]
Message-ID: <20150422222033.GF4069@free.fr> (raw)
In-Reply-To: <1429740838-8577-1-git-send-email-gustavo@zacarias.com.ar>
Gustavo, All,
On 2015-04-22 19:13 -0300, Gustavo Zacarias spake thusly:
> The package was added after the last iteration of the non-ipv6
> toolchain removal, so adjust it.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Now it occurs to me that we should probably have kep a hiden symbol,
like so:
config BR2_INET_IPV6
bool
default y
so that existing out-of-tree packages (e.g. in some br2-external trees)
continue to work seamlessly...
But them users would probably never notice the breakage, so maybe better
break early...
Regards,
Yann E. MORIN.
> ---
> package/mosquitto/Config.in | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
> index 8f579f8..50937d0 100644
> --- a/package/mosquitto/Config.in
> +++ b/package/mosquitto/Config.in
> @@ -1,7 +1,6 @@
> config BR2_PACKAGE_MOSQUITTO
> bool "mosquitto"
> depends on BR2_USE_MMU # fork()
> - depends on BR2_INET_IPV6
> depends on !BR2_STATIC_LIBS # builds .so
> help
> Mosquitto is an open source message broker that implements
> @@ -14,6 +13,6 @@ config BR2_PACKAGE_MOSQUITTO
>
> http://mosquitto.org/
>
> -comment "mosquitto needs a toolchain w/ IPv6, dynamic library"
> +comment "mosquitto needs a toolchain w/ dynamic library"
> depends on BR2_USE_MMU
> - depends on !BR2_INET_IPV6 || BR2_STATIC_LIBS
> + depends on BR2_STATIC_LIBS
> --
> 2.0.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-22 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 22:13 [Buildroot] [PATCH] mosquitto: remove ipv6 depends Gustavo Zacarias
2015-04-22 22:20 ` Yann E. MORIN [this message]
2015-04-23 7:48 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422222033.GF4069@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox