From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] psplash: move systemd service files to /usr/lib
Date: Wed, 22 Apr 2015 22:51:43 +0200 [thread overview]
Message-ID: <20150422225143.724a7bfb@free-electrons.com> (raw)
In-Reply-To: <1429638638-28695-3-git-send-email-mike@mikebwilliams.com>
Dear Mike Williams,
On Tue, 21 Apr 2015 13:50:35 -0400, Mike Williams wrote:
> Signed-off-by: Mike Williams <mike@mikebwilliams.com>
> ---
> package/psplash/psplash.mk | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
> index 5901547..85c0fb8 100644
> --- a/package/psplash/psplash.mk
> +++ b/package/psplash/psplash.mk
> @@ -11,15 +11,15 @@ PSPLASH_AUTORECONF = YES
>
> define PSPLASH_INSTALL_INIT_SYSTEMD
> $(INSTALL) -D -m 644 package/psplash/psplash-start.service \
> - $(TARGET_DIR)/etc/systemd/system/psplash-start.service
> + $(TARGET_DIR)/usr/lib/systemd/system/psplash-start.service
> $(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants
> - ln -sf ../psplash-start.service \
> + ln -sf ../../../../usr/lib/systemd/system/psplash-start.service \
> $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants/
We usually use a full destination path here.
>
> $(INSTALL) -D -m 644 package/psplash/psplash-quit.service \
> - $(TARGET_DIR)/etc/systemd/system/psplash-quit.service
> + $(TARGET_DIR)/usr/lib/systemd/system/psplash-quit.service
> $(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> - ln -sf ../psplash-quit.service \
> + ln -sf ../../../../usr/lib/systemd/system/psplash-quit.service \
> $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/
And here.
Nonetheless, I've applied the patch as is, I'll let you decide in which
direction the systemd service installation commands should be
made consistent across packages.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-22 20:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 17:50 [Buildroot] [PATCH 0/5] systemd service file cleanups Mike Williams
2015-04-21 17:50 ` [Buildroot] [PATCH 1/5] avahi: systemd cleanups Mike Williams
2015-04-22 20:19 ` Thomas Petazzoni
2015-04-21 17:50 ` [Buildroot] [PATCH 2/5] psplash: move systemd service files to /usr/lib Mike Williams
2015-04-22 20:51 ` Thomas Petazzoni [this message]
2015-04-21 17:50 ` [Buildroot] [PATCH 3/5] rsyslog: fix systemd service installation Mike Williams
2015-04-22 20:53 ` Thomas Petazzoni
2015-04-21 17:50 ` [Buildroot] [PATCH 4/5] ofono: enable systemd service by default Mike Williams
2015-04-22 20:56 ` Thomas Petazzoni
2015-04-21 17:50 ` [Buildroot] [PATCH 5/5] connman: " Mike Williams
2015-04-22 20:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422225143.724a7bfb@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox