From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/nvidia-driver: don't install gl.pc when not providing libgl
Date: Sat, 25 Apr 2015 10:34:49 +0200 [thread overview]
Message-ID: <20150425103449.7013d56f@free-electrons.com> (raw)
In-Reply-To: <1429911597-19411-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Fri, 24 Apr 2015 23:39:57 +0200, Yann E. MORIN wrote:
> When nvidia-driver does not provide libgl (i.e. when it does not install
> the X.org driver), it should also not install gl.pc, otherwise, packages
> that depend on pkg-config will mis-detect presence of GL and fail to
> build, like vlc:
>
> http://autobuild.buildroot.org/results/724/724fce8ce51c2c0578192b1369a1cfcea3d72638/
>
> So, only install gl.pc when we install the X.org driver. Similarly, we
> do not need to install libGL.la either.
>
> Reported-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/nvidia-driver/nvidia-driver.mk | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-04-25 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 21:39 [Buildroot] [PATCH] package/nvidia-driver: don't install gl.pc when not providing libgl Yann E. MORIN
2015-04-25 6:38 ` Bernd Kuhls
2015-04-25 8:34 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425103449.7013d56f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox