Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] python-pyqt: fix PyQt_qreal_double enabling/disabling
Date: Sat, 25 Apr 2015 14:34:35 +0200	[thread overview]
Message-ID: <20150425143435.7d1b3ea7@free-electrons.com> (raw)
In-Reply-To: <1429958478-29114-1-git-send-email-gwenj@trabucayre.com>

Dear Gwenhael Goavec-Merou,

On Sat, 25 Apr 2015 12:41:16 +0200, Gwenhael Goavec-Merou wrote:

> +# PyQt_qreal_double must be disabled on ARM or when QT_NO_FPU is set
> +# QT_NO_FPU is set for ARM, SH4 and SH4A
> +ifeq ($(BR2_arm)$(BR2_armeb)$(BR2_sh4)$(BR2_sh4a)$(BR2_sh4aeb),y)
> +PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_qreal_double
> +endif
> +
> +# QT_NO_FPU is also set for QWS on misp
> +ifeq ($(BR2_PACKAGE_QT_EMBEDDED)x$(BR2_mipsel)$(BR2_mips),yxy)
> +PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_qreal_double
> +endif

Can we introduce a hidden Config.in option instead, like:

BR2_PYTHON_PYQT_ARCH_USES_QREAL_FLOAT
	bool
	default y if BR2_arm || BR2_armeb
	default y if BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb
	default y if (BR2_mipsel || BR2_mips) && BR2_PACKAGE_QT_EMBEDDED

And then:

ifeq ($(BR2_PYTHON_PYQT_ARCH_USES_QREAL_FLOAT),y)
PYTHON_PYQT_QTDETAIL_DISABLE_FEATURES += PyQt_qreal_double
endif

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-04-25 12:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25 10:41 [Buildroot] [PATCH v2 1/3] python-pyqt: fix PyQt_qreal_double enabling/disabling Gwenhael Goavec-Merou
2015-04-25 10:41 ` [Buildroot] [PATCH v2 2/3] python-pyqt: fix install Gwenhael Goavec-Merou
2015-05-17  6:59   ` Peter Korsgaard
2015-04-25 10:41 ` [Buildroot] [PATCH v2 3/3] qt: fix webkit dependencies Gwenhael Goavec-Merou
2015-05-17  7:00   ` Peter Korsgaard
2015-04-25 12:34 ` Thomas Petazzoni [this message]
2015-04-26 10:14 ` [Buildroot] [PATCH v2 1/3] python-pyqt: fix PyQt_qreal_double enabling/disabling Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150425143435.7d1b3ea7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox