From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH RESEND] qt: add QT_COORD_TYPE to double option
Date: Sun, 26 Apr 2015 00:22:17 +0200 [thread overview]
Message-ID: <20150425222217.GW4275@free.fr> (raw)
In-Reply-To: <1429691658-13139-1-git-send-email-richard.genoud@gmail.com>
Richard, All,
On 2015-04-22 10:34 +0200, Richard Genoud spake thusly:
> From: Julien D'Ascenzio <jdascenzio@paratronic.fr>
>
> On ARM-based platforms, qreal is a typedef for float for performance
> reasons.
> But we may want a double precision anyway.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[build-tested only with a minimal Qt config for cCortex A7]
Regards,
Yann E. MORIN.
> ---
> Rebased and compiled on master (21 april 2015) for arm926ej-s
>
> package/qt/Config.in | 7 +++++++
> package/qt/qt.mk | 5 +++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 43f5a0fc7c0d..c3922abb9f23 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -120,6 +120,13 @@ config BR2_PACKAGE_QT_CONFIG_FILE
> This option allows to set the path of such a configuration
> file, which Buildroot will give to Qt at compile time.
>
> +config BR2_PACKAGE_QT_QT_COORD_TYPE_DOUBLE
> + bool "QT_COORD_TYPE to double"
> + help
> + Set QT_COORD_TYPE to double
> + On ARM-based platforms, qreal is a typedef for float for performance reasons.
> + If unsure say n.
> +
> config BR2_PACKAGE_QT_QT3SUPPORT
> bool "Compatibility with Qt3"
> depends on BR2_PACKAGE_QT_GUI_MODULE
> diff --git a/package/qt/qt.mk b/package/qt/qt.mk
> index 76acbfcea476..ce0a21ab288a 100644
> --- a/package/qt/qt.mk
> +++ b/package/qt/qt.mk
> @@ -46,6 +46,11 @@ QT_CFLAGS += -marm
> QT_CXXFLAGS += -marm
> endif
>
> +ifeq ($(BR2_PACKAGE_QT_QT_COORD_TYPE_DOUBLE),y)
> +QT_CFLAGS += -DQT_COORD_TYPE=double
> +QT_CXXFLAGS += -DQT_COORD_TYPE=double
> +endif
> +
> ifeq ($(BR2_PACKAGE_QT_QT3SUPPORT),y)
> QT_CONFIGURE_OPTS += -qt3support
> else
> --
> 2.3.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-25 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 10:49 [Buildroot] [PATCH] qt: add QT_COORD_TYPE to double option Richard Genoud
2015-04-22 8:34 ` [Buildroot] [PATCH RESEND] " Richard Genoud
2015-04-25 22:22 ` Yann E. MORIN [this message]
2015-04-26 10:16 ` Thomas Petazzoni
2015-04-28 9:42 ` Peter Korsgaard
2015-04-28 10:24 ` Richard Genoud
2015-04-28 15:42 ` [Buildroot] [PATCH] qt: QT_COORD_TYPE_DOUBLE should only be set on soft float Richard Genoud
2015-04-28 19:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150425222217.GW4275@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox